Skip to content

Commit f832f27

Browse files
committed
rabbit_feature_flags: Hide required feature flags in management UI
[Why] They just add noise to the UI and there is nothing the user can do about them at that point. Given their number will only increase, let's hide them to let the user focus on the feature flags they can act on.
1 parent 9645c81 commit f832f27

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

deps/rabbitmq_management/priv/www/js/tmpl/feature-flags.ejs

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,14 @@
3030
<%
3131
for (var i = 0; i < feature_flags.length; i++) {
3232
var feature_flag = feature_flags[i];
33-
if (feature_flag.stability == "experimental") {
34-
continue;
35-
}
33+
if (feature_flag.stability == "required") {
34+
/* Hide required feature flags. There is nothing the user can do
35+
* about them and they just add noise to the UI. */
36+
continue;
37+
}
38+
if (feature_flag.stability == "experimental") {
39+
continue;
40+
}
3641
var state_color = "grey";
3742
if (feature_flag.state == "enabled") {
3843
state_color = "green";
@@ -103,9 +108,9 @@ These flags can be enabled in production deployments after an appropriate amount
103108
<%
104109
for (var i = 0; i < feature_flags.length; i++) {
105110
var feature_flag = feature_flags[i];
106-
if (feature_flag.stability != "experimental") {
107-
continue;
108-
}
111+
if (feature_flag.stability != "experimental") {
112+
continue;
113+
}
109114
var state_color = "grey";
110115
if (feature_flag.state == "enabled") {
111116
state_color = "green";
@@ -119,14 +124,14 @@ These flags can be enabled in production deployments after an appropriate amount
119124
<td><%= fmt_string(feature_flag.name) %></td>
120125
<td class="c">
121126
<% if (feature_flag.state == "disabled") { %>
122-
<div>
127+
<div>
123128
<input id="<%= feature_flag.name %>" type="checkbox" class="riskCheckbox" onclick="this.parentNode.querySelector('.enable-feature-flag input[type=submit]').disabled = !this.checked;">
124129
<label for="<%= feature_flag.name %>">I understand that once enabled, this feature flag cannot be disabled</label><br>
125-
<br>
130+
<br>
126131
<form action="#/feature-flags-enable" method="put" style="display: inline-block" class="enable-feature-flag">
127132
<input type="hidden" name="name" value="<%= fmt_string(feature_flag.name) %>"/>
128133
<input type="submit" value="Enable" class="c" disabled="disabled"/>
129-
</div>
134+
</div>
130135
</form>
131136
<% } else { %>
132137
<abbr class="status-<%= fmt_string(state_color) %>"

0 commit comments

Comments
 (0)