Remove code_server_cache

It was introduced to fix a problem in a feature that's no
longer used, so we remove both the feature and code_server_cache.

Author: lhoguin

deps/rabbit/src/code_server_cache.erl

@@ -81,7 +81,7 @@
 
 -rabbit_boot_step({database,
                    [{mfa,         {rabbit_db, init, []}},
-                    {requires,    code_server_cache},
+                    {requires,    rabbit_registry},
                     {enables,     external_infrastructure}]}).
 
 -rabbit_boot_step({networking_metadata_store,
@@ -96,12 +96,6 @@
                     {requires,    database},
                     {enables,     external_infrastructure}]}).
 
--rabbit_boot_step({code_server_cache,
-                   [{description, "code_server cache server"},
-                    {mfa,         {rabbit_sup, start_child, [code_server_cache]}},
-                    {requires,    rabbit_alarm},
-                    {enables,     worker_pool}]}).
-
 -rabbit_boot_step({worker_pool,
                    [{description, "default worker pool"},
                     {mfa,         {rabbit_sup, start_supervisor_child,

deps/rabbit/src/rabbit.erl

@@ -16,9 +16,6 @@
 -export([list_local/0,
          conserve_resources/3]).
 
-%% For testing only
--export([extract_extra_auth_props/4]).
-
 -include_lib("rabbit_common/include/rabbit.hrl").
 -include_lib("rabbit_common/include/rabbit_misc.hrl").
 -include_lib("kernel/include/logger.hrl").
@@ -85,7 +82,7 @@ auth_fun({Username, Password}, VHost, ExtraAuthProps) ->
 %% during the first authentication. However, we do have the outcome from such successful authentication.
 
 connect(Creds, VHost, Protocol, Pid, Infos) ->
-    ExtraAuthProps = append_authz_backends(extract_extra_auth_props(Creds, VHost, Pid, Infos), Infos),
+    ExtraAuthProps = get_authz_backends(Infos),
 
     AuthFun = auth_fun(Creds, VHost, ExtraAuthProps),
     case rabbit_boot_state:has_reached_and_is_active(core_started) of
@@ -119,37 +116,8 @@ connect(Creds, VHost, Protocol, Pid, Infos) ->
         false -> {error, broker_not_found_on_node}
     end.
 
-extract_extra_auth_props(Creds, VHost, Pid, Infos) ->
-    case extract_protocol(Infos) of
-        undefined ->
-            [];
-        Protocol ->
-            maybe_call_connection_info_module(Protocol, Creds, VHost, Pid, Infos)
-    end.
-
-
-append_authz_backends(AuthProps, Infos) ->
-    case proplists:get_value(authz_backends, Infos, undefined) of
-        undefined -> AuthProps;
-        AuthzBackends -> AuthProps ++ AuthzBackends
-    end.
-
-extract_protocol(Infos) ->
-    case proplists:get_value(protocol, Infos, undefined) of
-        {Protocol, _Version} ->
-            Protocol;
-        _ ->
-            undefined
-    end.
-
-maybe_call_connection_info_module(Protocol, Creds, VHost, Pid, Infos) ->
-    Module = rabbit_data_coercion:to_atom(string:to_lower(
-        "rabbit_" ++
-        lists:flatten(string:replace(rabbit_data_coercion:to_list(Protocol), " ", "_", all)) ++
-        "_connection_info")
-    ),
-    Args = [Creds, VHost, Pid, Infos],
-    code_server_cache:maybe_call_mfa(Module, additional_authn_params, Args, []).
+get_authz_backends(Infos) ->
+    proplists:get_value(authz_backends, Infos, []).
 
 is_vhost_alive(VHost, {Username, _Password}, Pid) ->
     PrintedUsername = case Username of

deps/rabbit/src/rabbit_direct.erl

@@ -30,8 +30,7 @@ groups() ->
           login_of_passwordless_user,
           set_tags_for_passwordless_user,
           change_password,
-          auth_backend_internal_expand_topic_permission,
-          rabbit_direct_extract_extra_auth_props
+          auth_backend_internal_expand_topic_permission
       ]}
     ].
 
@@ -221,28 +220,6 @@ set_tags_for_passwordless_user1(_Config) ->
     passed.
 
 
-rabbit_direct_extract_extra_auth_props(_Config) ->
-    {ok, CSC} = code_server_cache:start_link(),
-    % no protocol to extract
-    [] = rabbit_direct:extract_extra_auth_props(
-        {<<"guest">>, <<"guest">>}, <<"/">>, 1,
-        [{name,<<"127.0.0.1:52366 -> 127.0.0.1:1883">>}]),
-    % protocol to extract, but no module to call
-    [] = rabbit_direct:extract_extra_auth_props(
-        {<<"guest">>, <<"guest">>}, <<"/">>, 1,
-        [{protocol, {'PROTOCOL_WITHOUT_MODULE', "1.0"}}]),
-    % see rabbit_dummy_protocol_connection_info module
-    % protocol to extract, module that returns a client ID
-    [{client_id, <<"DummyClientId">>}] = rabbit_direct:extract_extra_auth_props(
-        {<<"guest">>, <<"guest">>}, <<"/">>, 1,
-        [{protocol, {'DUMMY_PROTOCOL', "1.0"}}]),
-    % protocol to extract, but error thrown in module
-    [] = rabbit_direct:extract_extra_auth_props(
-        {<<"guest">>, <<"guest">>}, <<"/">>, -1,
-        [{protocol, {'DUMMY_PROTOCOL', "1.0"}}]),
-    gen_server:stop(CSC),
-    ok.
-
 auth_backend_internal_expand_topic_permission(_Config) ->
     ExpandMap = #{<<"username">> => <<"guest">>, <<"vhost">> => <<"default">>},
     %% simple case

deps/rabbit/test/rabbit_dummy_protocol_connection_info.erl

@@ -83,17 +83,11 @@ propagate_context_to_auth_backend1() ->
     password = <<"guest">>,
     adapter_info = #amqp_adapter_info{additional_info = [
         {variable_map, #{<<"key1">> => <<"value1">>}}
-      ],
-      protocol = {'FOO_PROTOCOL', '1.0'} %% this will trigger a call to rabbit_foo_protocol_connection_info
+      ]
     }
   },
   {ok, Conn} = amqp_connection:start(AmqpParams),
 
-  %% rabbit_direct will call the rabbit_foo_protocol_connection_info module to extract information
-  %% this information will be propagated to the authentication backend
-  [{authentication, AuthProps}] = rabbit_auth_backend_context_propagation_mock:get(authentication),
-  ?assertEqual(<<"value1">>, proplists:get_value(key1, AuthProps)),
-
   %% variable_map is propagated from rabbit_direct to the authorization backend
   [{vhost_access, AuthzData}] = rabbit_auth_backend_context_propagation_mock:get(vhost_access),
   ?assertEqual(<<"value1">>, maps:get(<<"key1">>, AuthzData)),