Move the try / catch into rabbit_networking.

Author: Simon MacMullen

src/rabbit_connection_sup.erl

@@ -29,7 +29,7 @@
 -ifdef(use_specs).
 
 -spec(start_link/0 :: () -> {'ok', pid(), pid()}).
--spec(reader/1 :: (pid()) -> pid() | noproc).
+-spec(reader/1 :: (pid()) -> pid()).
 
 -endif.
 
@@ -57,11 +57,7 @@ start_link() ->
     {ok, SupPid, ReaderPid}.
 
 reader(Pid) ->
-    try
-        hd(supervisor2:find_child(Pid, reader))
-    catch exit:{noproc, _} ->
-            noproc
-    end.
+    hd(supervisor2:find_child(Pid, reader)).
 
 %%--------------------------------------------------------------------------
 

src/rabbit_networking.erl

@@ -310,7 +310,11 @@ connections_local() ->
     [Reader ||
         {_, ConnSup, supervisor, _}
             <- supervisor:which_children(rabbit_tcp_client_sup),
-        Reader <- [rabbit_connection_sup:reader(ConnSup)],
+        Reader <- [try
+                       rabbit_connection_sup:reader(ConnSup)
+                   catch exit:{noproc, _} ->
+                           noproc
+                   end],
         Reader =/= noproc].
 
 connection_info_keys() -> rabbit_reader:info_keys().