Add ssl_options to rabbitmq_auth_backend_http's schema #11344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
reviewed
May 31, 2024
So that dialyzer can find the missing functions
lukebakken
approved these changes
May 31, 2024
michaelklishin
requested changes
Jun 1, 2024
Collaborator
There was a problem hiding this comment.
We should not use typical certificate and key filenames for sample files with invalid data, so
rabbitmq_auth_backend_http/test/config_schema_SUITE_data/certs/cacert.pem
with its current contents and its intended use in the test suite should instead be something like
rabbitmq_auth_backend_http/test/config_schema_SUITE_data/certs/invalid_cacert.pem
Suggested by @michaelklishin
michaelklishin
approved these changes
Jun 2, 2024
michaelklishin
approved these changes
Jun 2, 2024
6 tasks
michaelklishin
added a commit
that referenced
this pull request
Jun 2, 2024
Add ssl_options to rabbitmq_auth_backend_http's schema (backport #11344)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Address feature request #10281
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply