Prefer monotonic time to measure durations #11389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monotonic time instead of wall clock time should be used to measure a duration. This is mostly a cosmetic change given that consumer timeouts are 30 mins by default. See also rabbitmq/khepri#239 #10928
the-mikedavis
approved these changes
Jun 6, 2024
michaelklishin
approved these changes
Jun 6, 2024
Collaborator
|
@Mergifyio backport v3.13.x |
✅ Backports have been created
|
Member
Author
|
|
michaelklishin
added a commit
that referenced
this pull request
Jun 6, 2024
Prefer monotonic time to measure durations (backport #11389)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monotonic time instead of wall clock time should be used to measure a duration.
This is mostly a cosmetic change given that consumer timeouts are 30 mins by default.
See also
rabbitmq/khepri#239
#10928