etcd peer discovery fixes #11439
Merged
etcd peer discovery fixes #11439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
requested changes
Jun 12, 2024
deps/rabbitmq_peer_discovery_etcd/src/rabbitmq_peer_discovery_etcd_v3_client.erl
Show resolved
Hide resolved
Instead of relying on the complex and non-determinstic default node selection mechanism inside peer discovery this change makes the etcd backend implemention make the leader selection itself based on the etcd create_revision of each entry. Although not spelled out anywhere explicitly is likely that a property called "Create Revision" is going to remain consistent throughout the lifetime of the etcd key. Either way this is likely to be an improvement on the current approach.
As the primary mirror may sometimes fail there is now a fall back.
kjnilsson
force-pushed
the
peer-discovery-etcd-fixes
branch
from
5494ac6 to
5a94049
Compare
dumbbell
approved these changes
Jun 12, 2024
Collaborator
|
@Mergifyio backport v3.13.x |
✅ Backports have been created
|
michaelklishin
added a commit
that referenced
this pull request
Jun 12, 2024
etcd peer discovery fixes (backport #11439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the complex and non-determinstic default node
selection mechanism inside peer discovery this change makes the
etcd backend implemention make the leader selection itself based on
the etcd
create_revisionof each entry. Although not spelled out anywhereexplicitly is likely that a property called "Create Revision" is going
to remain consistent throughout the lifetime of the etcd key.
Either way this is likely to be an improvement on the current approach.