peer_discovery_tmp_hidden_node_SUITE: Use IP address to simulate a ng node name (backport #11449) #11450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng node name [Why] The `longnames`-based testcase depends on a copnfigured FQDN. Buildbuddy hosts were incorrectly configured and were lacking one. As a workaround, `/etc/hosts` was modified to add an FQDN. We don't use Buildbuddy anymore, but the problem also appeared on team members' Broadcom-managed laptops (also having an incomplete network configuration). More importantly, GitHub workers seem to have the same problem, but randomly! At this point, we can't rely on the host's correct network configuration. [How] The testsuite is modified to use a hard-coded IP address, 127.0.0.1, to simulate a long Erlang node name (i.e. it has dots). (cherry picked from commit df65831)
Collaborator
|
Could we please wait for CI to be green before merging something, even though we have to restart some jobs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
longnames-based testcase depends on a copnfigured FQDN. Buildbuddy hosts were incorrectly configured and were lacking one. As a workaround,/etc/hostswas modified to add an FQDN.We don't use Buildbuddy anymore, but the problem also appeared on team members' Broadcom-managed laptops (also having an incomplete network configuration). More importantly, GitHub workers seem to have the same problem, but randomly!
At this point, we can't rely on the host's correct network configuration.
How
The testsuite is modified to use a hard-coded IP address, 127.0.0.1, to simulate a long Erlang node name (i.e. it has dots).
This is an automatic backport of pull request #11449 done by Mergify.