Management UI: Fix internal_server_error args for put vhost failures (backport #11585) #11590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rabbit_mgmt_util:internal_server_error/4` expects an atom or binary and a string formattable term (`~ts`) as arguments but `rabbit_mgmt_wm_vhost` passes charlists and any term. This can cause a log formatter crash and an unexpected message in the management UI when attempting to add a vhost while a cluster is in a minority with Khepri enabled for example. We can pass atoms for the `Error` parameter and binaries or strings for the `Reason` parameter to fix both issues. (cherry picked from commit 8f60b69)
Collaborator
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rabbit_mgmt_util:internal_server_error/4expects an atom or binary and a string formattable term (~ts) as arguments butrabbit_mgmt_wm_vhostpasses charlists and any term. This can cause a log formatter crash and an unexpected message in the management UI when attempting to add a vhost while a cluster is in a minority with Khepri enabled for example.We can pass atoms for the
Errorparameter and binaries or strings for theReasonparameter to fix both issues.This is an automatic backport of pull request #11585 done by Mergify.