Default queue type (DQT): fall back to node-wide default when virtual host has no metadata set #12109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
changed the title
This relaxes assert_list/2 assertion to not require the size of an actually returned list element to be exactly equal to the size of the expected one. Sometimes it makes perfect sense to not assert on every single key but only a subset, and with this change, it now will be possible. Individual tests may choose to assert on all keys by listing them explicitly.
Collaborator
Author
|
I'm adding more redeclaration tests for classic queues just in case:
In particular, the behavior of redeclaration of a classic queue with |
michaelklishin
added a commit
that referenced
this pull request
Aug 24, 2024
Default queue type (DQT): fall back to node-wide default when virtual host has no metadata set (backport #12109)
michaelklishin
added a commit
that referenced
this pull request
Aug 24, 2024
SimonUnge
added a commit
to SimonUnge/rabbitmq-server
that referenced
this pull request
Aug 30, 2024
Partial Backport of rabbitmq#12109
12 tasks
SimonUnge
added a commit
to SimonUnge/rabbitmq-server
that referenced
this pull request
Sep 5, 2024
Partial Backport of rabbitmq#12109 Bump
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when virtual host does not have any metadata.
With this change, an
x-queue-typeheader will be injected into optional queue argumentsand returned as part of definitions and the HTTP API in virtually all cases.
This also relaxes the
assert_list/2assertion a bit: itno longer requires the size of an actually returned list element
to be exactly equal to the size of the expected one.
Sometimes it makes perfect sense to not assert on
every single key but only a subset, and with this
change, it now will be possible.
Individual tests may choose to assert on all
keys by listing them explicitly.
References #11541 #11457 #11528