Convert array from AMQP 1.0 to AMQP 0.9.1 #12571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following crash when an AMQP 0.9.1 client consumes an AMQP 1.0
encoded message that contains an array value in message annotations:
```
crasher:
initial call: rabbit_channel:init/1
pid: <0.685.0>
registered_name: []
exception exit: {function_clause,
[{mc_amqpl,to_091,
[<<"x-array">>,
{array,utf8,[{utf8,<<"e1">>},{utf8,<<"e2">>}]}],
[{file,"mc_amqpl.erl"},{line,737}]},
{mc_amqpl,'-convert_from/3-fun-3-',1,
[{file,"mc_amqpl.erl"},{line,168}]},
{lists,filtermap_1,2,
[{file,"lists.erl"},{line,2279}]},
{mc_amqpl,convert_from,3,
[{file,"mc_amqpl.erl"},{line,158}]},
{mc,convert,3,[{file,"mc.erl"},{line,332}]},
{rabbit_channel,handle_deliver0,4,
[{file,"rabbit_channel.erl"},{line,2619}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,2151}]},
{lists,foldl,3,[{file,"lists.erl"},{line,2146}]}]}
```
ansd
force-pushed
the
amqp-convert-array
branch
from
97fef60 to
5619f2e
Compare
kjnilsson
approved these changes
Oct 22, 2024
ansd
added a commit
that referenced
this pull request
Oct 22, 2024
* Convert array from AMQP 1.0 to AMQP 0.9.1
Fix the following crash when an AMQP 0.9.1 client consumes an AMQP 1.0
encoded message that contains an array value in message annotations:
```
crasher:
initial call: rabbit_channel:init/1
pid: <0.685.0>
registered_name: []
exception exit: {function_clause,
[{mc_amqpl,to_091,
[<<"x-array">>,
{array,utf8,[{utf8,<<"e1">>},{utf8,<<"e2">>}]}],
[{file,"mc_amqpl.erl"},{line,737}]},
{mc_amqpl,'-convert_from/3-fun-3-',1,
[{file,"mc_amqpl.erl"},{line,168}]},
{lists,filtermap_1,2,
[{file,"lists.erl"},{line,2279}]},
{mc_amqpl,convert_from,3,
[{file,"mc_amqpl.erl"},{line,158}]},
{mc,convert,3,[{file,"mc.erl"},{line,332}]},
{rabbit_channel,handle_deliver0,4,
[{file,"rabbit_channel.erl"},{line,2619}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,2151}]},
{lists,foldl,3,[{file,"lists.erl"},{line,2146}]}]}
```
(cherry picked from commit 814d44d)
# Conflicts:
# deps/amqp10_client/src/amqp10_msg.erl
* Fix conflict
---------
Co-authored-by: David Ansari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following crash when an AMQP 0.9.1 client consumes an AMQP 1.0 encoded message that contains an array value in message annotations: