4.1.x: Use preprocessor macros for building Khepri path patterns #12723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
requested changes
Nov 20, 2024
the-mikedavis
force-pushed
the
md/khepri-path-preproc-macros
branch
from
0167637 to
13d4b66
Compare
the-mikedavis
force-pushed
the
md/khepri-path-preproc-macros
branch
from
13d4b66 to
e27046d
Compare
This fixes erlang_ls's header resolution. Previously it would confuse the include_lib of the `khepri.hrl` from Khepri with this header in the rabbit app. This header is also specific to how rabbit uses Khepri so I think the new name fits better.
the-mikedavis
force-pushed
the
md/khepri-path-preproc-macros
branch
from
8514c9b to
c3c7675
Compare
the-mikedavis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is two mostly cosmetic refactors:
include/khepri.hrltoinclude/rabbit_khepri.hrlinrabbit. This helps ErlangLS find the header. It seems to confuse this header with one of the same name fromkhepriitself.khepri_adv:node_props_map().