Fix transient queue detection (backport #12840)

deps/rabbit/src/rabbit_amqqueue.erl

@@ -118,12 +118,19 @@
      }}).
 
 are_transient_nonexcl_used(_) ->
-    case rabbit_db_queue:list_transient() of
-        {ok, Queues} ->
-            NonExclQueues = [Q || Q <- Queues, not is_exclusive(Q)],
-            length(NonExclQueues) > 0;
-        {error, _} ->
-            undefined
+    case rabbit_db:is_virgin_node() of
+        true ->
+            %% a virgin node can't have any queues and the check is performed before
+            %% metadata store is ready, so skip the query
+            false;
+        false ->
+            case rabbit_db_queue:list_transient() of
+                {ok, Queues} ->
+                    NonExclQueues = [Q || Q <- Queues, not is_exclusive(Q)],
+                    length(NonExclQueues) > 0;
+                {error, _} ->
+                    undefined
+            end
     end.
 
 -define(CONSUMER_INFO_KEYS,

deps/rabbit/src/rabbit_db_queue.erl

@@ -985,7 +985,7 @@ list_transient() ->
        }).
 
 list_transient_in_mnesia() ->
-    Pattern = amqqueue:pattern_match_all(),
+    Pattern = amqqueue:pattern_match_on_durable(false),
     AllQueues = mnesia:dirty_match_object(
                   ?MNESIA_TABLE,
                   Pattern),

deps/rabbitmq_cli/lib/rabbitmq/cli/diagnostics/commands/check_certificate_expiration_command.ex

@@ -77,7 +77,7 @@ defmodule RabbitMQ.CLI.Diagnostics.Commands.CheckCertificateExpirationCommand do
   end
 
   def unit_label(1, unit) do
-    unit |> String.slice(0..-2)
+    unit |> String.slice(0..-2//-1)
   end
 
   def unit_label(_within, unit) do