mirrored_supervisor: Catch timeout from Khepri in hanlde_info/2
#12853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] It can return an error.
[Why] The code assumed that the transaction would always succeed. It was kind of the case with Mnesia because it would throw an exception if it failed. Khepri returns an error instead. The code has to handle it. In particular, we see timeouts in CI and before this patch, they caused a crash because the list comprehension was asked to work on a tuple. [How] We now retry a few times for 10 seconds.
michaelklishin
added a commit
that referenced
this pull request
Dec 2, 2024
mirrored_supervisor: Catch timeout from Khepri in `hanlde_info/2` (backport #12853)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The code assumed that the transaction would always succeed. It was kind of the case with Mnesia because it would throw an exception if it failed.
Khepri returns an error instead. The code has to handle it. In particular, we see timeouts in CI and before this patch, they caused a crash because the list comprehension was asked to work on a tuple.
How
We now retry a few times for 10 seconds.