Disallow transient entities in RabbitMQ AMQP 1.0 Erlang client #12947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transient (i.e. `durable=false`) exchanges and queues are deprecated. Khepri will store all entities durably. (Even exclusive queues will be stored durably. Exclusive queues are still deleted when the declaring connection is closed.) Similar to how the RabbitMQ AMQP 1.0 Java client already disallows the creation of transient exchanges and queues, this commit will prohibit the declaration of transient exchanges and queues in the RabbitMQ AMQP 1.0 Erlang client starting with RabbitMQ 4.1.
ansd
force-pushed
the
client-durable-entities
branch
from
d202322 to
98b9af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transient (i.e.
durable=false) exchanges and queues are deprecated.Khepri will store all entities durably.
(Even exclusive queues will be stored durably. Exclusive queues are still deleted when the declaring connection is closed.)
Similar to how the RabbitMQ AMQP 1.0 Java client already disallows the creation of transient exchanges and queues, this commit will prohibit the declaration of transient exchanges and queues in the RabbitMQ AMQP 1.0 Erlang client starting with RabbitMQ 4.1.