Ignore stream connections in unexpected states (backport #13674) (backport #13677) #13678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A connection which terminated before it was fully established would lead to a function_clause, since metadata is not available to really call notify_connection_closed. We can just ignore such connections and not notify about them. Resolves https://github.com/rabbitmq/rabbitmq-server/discussions/13670 (cherry picked from commit 09ed8fd) (cherry picked from commit 268b15b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A connection which terminated before it was fully established would lead to a function_clause, since metadata is not available to really call notify_connection_closed. We can just ignore such connections and not notify about them.
Resolves #13670
This is an automatic backport of pull request #13674 done by Mergify.
This is an automatic backport of pull request #13677 done by Mergify.