From cd2aa86d13ce7bdef2bf04ecc5c449037332a7e3 Mon Sep 17 00:00:00 2001 From: Michal Kuratczyk Date: Thu, 10 Apr 2025 15:53:08 +0200 Subject: [PATCH] Remove log level tests When debug logging is enabled, we log something at each log level to test if logs are emitted. I don't think this is particularly useful, but it's certainly annoying, because I constatnly need to filter out these logs when searching if any errors happened during tests. --- deps/rabbit/src/rabbit_prelaunch_logging.erl | 38 +------------------- 1 file changed, 1 insertion(+), 37 deletions(-) diff --git a/deps/rabbit/src/rabbit_prelaunch_logging.erl b/deps/rabbit/src/rabbit_prelaunch_logging.erl index c20b316fd89a..d015583a1ecb 100644 --- a/deps/rabbit/src/rabbit_prelaunch_logging.erl +++ b/deps/rabbit/src/rabbit_prelaunch_logging.erl @@ -527,12 +527,7 @@ configure_logger(Context) -> %% We can now install the new handlers. The function takes care of %% removing previously configured handlers (after installing the new %% ones to ensure we don't loose a message). - ok = install_handlers(Handlers), - - %% Let's log a message per log level (if debug logging is enabled). This - %% is handy if the user wants to verify the configuration is what he - %% expects. - ok = maybe_log_test_messages(LogConfig3). + ok = install_handlers(Handlers). -spec get_log_configuration_from_app_env() -> log_config(). @@ -1690,34 +1685,3 @@ get_less_severe_level(LevelA, LevelB) -> lt -> LevelA; _ -> LevelB end. - --spec maybe_log_test_messages(log_config()) -> ok. - -maybe_log_test_messages( - #{per_category := #{prelaunch := #{level := debug}}}) -> - log_test_messages(); -maybe_log_test_messages( - #{global := #{level := debug}}) -> - log_test_messages(); -maybe_log_test_messages(_) -> - ok. - --spec log_test_messages() -> ok. - -log_test_messages() -> - ?LOG_DEBUG("Logging: testing debug log level", - #{domain => ?RMQLOG_DOMAIN_PRELAUNCH}), - ?LOG_INFO("Logging: testing info log level", - #{domain => ?RMQLOG_DOMAIN_PRELAUNCH}), - ?LOG_NOTICE("Logging: testing notice log level", - #{domain => ?RMQLOG_DOMAIN_PRELAUNCH}), - ?LOG_WARNING("Logging: testing warning log level", - #{domain => ?RMQLOG_DOMAIN_PRELAUNCH}), - ?LOG_ERROR("Logging: testing error log level", - #{domain => ?RMQLOG_DOMAIN_PRELAUNCH}), - ?LOG_CRITICAL("Logging: testing critical log level", - #{domain => ?RMQLOG_DOMAIN_PRELAUNCH}), - ?LOG_ALERT("Logging: testing alert log level", - #{domain => ?RMQLOG_DOMAIN_PRELAUNCH}), - ?LOG_EMERGENCY("Logging: testing emergency log level", - #{domain => ?RMQLOG_DOMAIN_PRELAUNCH}).