Skip to content

Conversation

@MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented May 2, 2025

Proposed Changes

This change allows a Selenium suite to work with two nodes, the main one, and other. This is necessary to test WSR feature but it can also be used for federation and shovel. Note that this is not a cluster of two nodes, which are explicitly recommended against, but rather two independent nodes (single node clusters) used for integration testing.

When running a test suite in interactive mode with two rabbitmqs, we start the main rabbitmq with the command start-rabbitmq and the other with start-other-rabbitmq. Moreover, one has to defined OTHER_PROFILE variable for the other rabbitmq. And the infrastructure generates the corresponding rabbitmq configuration from the active profiles the same way it is done for the main rabbitmq.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

@MarcialRosales MarcialRosales self-assigned this May 2, 2025
@MarcialRosales MarcialRosales changed the title Launch other rabbitmq Launch other rabbitmq from a selenium test suite May 2, 2025
@michaelklishin michaelklishin changed the title Launch other rabbitmq from a selenium test suite Launch abother node from a Selenium test suite May 2, 2025
@MarcialRosales MarcialRosales changed the title Launch abother node from a Selenium test suite Launch another node from a Selenium test suite May 3, 2025
@MarcialRosales MarcialRosales changed the title Launch another node from a Selenium test suite Launch another rabbitmq server from a Selenium test suite May 3, 2025
it was necessary to add a queue first before checking which
columns are available
@MarcialRosales MarcialRosales marked this pull request as ready for review May 3, 2025 11:27
@michaelklishin michaelklishin added this to the 4.2.0 milestone May 3, 2025
@michaelklishin michaelklishin merged commit cc33379 into main May 3, 2025
271 checks passed
@michaelklishin michaelklishin deleted the launch-other-rabbitmq branch May 3, 2025 14:37
michaelklishin added a commit that referenced this pull request May 3, 2025
michaelklishin added a commit that referenced this pull request May 3, 2025
Launch another rabbitmq server from a Selenium test suite (backport #13843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants