Move file_handle_cache and vm_memory_monitor back to rabbit
#13861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
move-os_mon-users-back-to-rabbit
branch
from
7679c8d to
0dc6365
Compare
[Why] They were moved from `rabbit` to `rabbit_common` several years ago to solve an dependency issue because `amqp_client` depended on the file handle cache. This is not the case anymore. [How] The modules are moved back to `rabbit`. `rabbit_common` doesn't need to depend on `os_mon` anymore. `rabbit` already depends on it, so no changes needed here. `include/rabbit_memory.hrl` and some test cases are moved as well to follow the `vm_memory_monitor` module.
dumbbell
force-pushed
the
move-os_mon-users-back-to-rabbit
branch
from
0dc6365 to
e58eb18
Compare
michaelklishin
approved these changes
May 7, 2025
michaelklishin
added a commit
that referenced
this pull request
May 7, 2025
Move `file_handle_cache` and `vm_memory_monitor` back to `rabbit` (backport #13861)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
They were moved from
rabbittorabbit_commonseveral years ago to solve an dependency issue becauseamqp_clientdepended on the file handle cache. This is not the case anymore.How
The modules are moved back to
rabbit.rabbit_commondoesn't need to depend onos_monanymore.rabbitalready depends on it, so no changes needed here.References #13861.