Skip to content

Test SAC with priority consumers #14000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

Test SAC with priority consumers #14000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd037a1
Verify previous active consumer is waiting
MarcialRosales Jun 2, 2025
8b7067d
Merge branch 'main' into test-sac-with-priorities
michaelklishin Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions deps/rabbit/test/rabbit_fifo_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1728,8 +1728,7 @@ single_active_consumer_priority_test(Config) ->
%% add a consumer with a higher priority, assert it becomes active
{CK2, make_checkout(C2, {auto, {simple_prefetch, 1}}, #{priority => 2})},
?ASSERT(#rabbit_fifo{consumers = #{CK2 := #consumer{status = up}},
waiting_consumers = [_]}),

waiting_consumers = [{CK1, _}]}),
%% enqueue a message
{E1Idx , rabbit_fifo:make_enqueue(Pid1, 1, msg1)},
?ASSERT(#rabbit_fifo{consumers = #{CK2 := #consumer{next_msg_id = 1,
Expand All @@ -1751,10 +1750,27 @@ single_active_consumer_priority_test(Config) ->
when map_size(Ch) == 0)

],
{_S1, _} = run_log(Config, S0, Entries, fun single_active_invariant/1),

ok.

{#rabbit_fifo{ cfg = #cfg{resource = Resource}}, StateMachineEvents} = run_log(Config, S0, Entries, fun single_active_invariant/1),
ModCalls = [ S || S = {mod_call, rabbit_quorum_queue, update_consumer_handler, _} <- StateMachineEvents ],

%% C1 should be added as single_active
assert_update_consumer_handler_state_transition(C1, Resource, true, single_active, lists:nth(1, ModCalls)),
%% C1 should transition to waiting because ...
assert_update_consumer_handler_state_transition(C1, Resource, false, waiting, lists:nth(2, ModCalls)),
%% C2 should become single_active
assert_update_consumer_handler_state_transition(C2, Resource, true, single_active, lists:nth(3, ModCalls)),
%% C2 should transition as waiting because ...
assert_update_consumer_handler_state_transition(C2, Resource, false, waiting, lists:nth(4, ModCalls)),
%% C3 is added as single_active
assert_update_consumer_handler_state_transition(C3, Resource, true, single_active, lists:nth(5, ModCalls)),

ok.

assert_update_consumer_handler_state_transition(ConsumerId, Resource, IsActive, UpdatedState, ModCall) ->
{mod_call,rabbit_quorum_queue,update_consumer_handler,
[Resource,
ConsumerId,
_,_,_,IsActive,UpdatedState,[]]} = ModCall.

single_active_consumer_priority_cancel_active_test(Config) ->
S0 = init(#{name => ?FUNCTION_NAME,
Expand Down
Loading