Shovels: Optimise amqp10 client messages for shovel usage (backport #14593) #14601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMQP10 shovels don't need the amqp10 message format, the binary can be translated directly into a message container and also the other way around. The new amqp10_raw_msg just stores the payload and information required to create the transfer frame, skipping a few unnecessary encoding/decoding operations of the AMQP10 sections. (cherry picked from commit 897260c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMQP10 shovels don't need the amqp10 message format, the binary can be translated directly into a message container and also the other way around. The new amqp10_raw_msg just stores the payload and information required to create the transfer frame, skipping a few unnecessary encoding/decoding operations of the AMQP10 sections.
These changes provide a 16% throughput improvement when shovelling 1.0 <-> 1.0
This is an automatic backport of pull request #14593 done by Mergify.