rabbitmq_streams: Check rabbit_queue_types is_enabled/0 during declare #14699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rabbit_amqqueue:declare/7` consults the `is_enabled/0` callback of `rabbit_queue_type` before attempting to create a queue. `rabbit_stream_manager` emulates `rabbit_amqqueue:declare/7` rather than calling it directly. To align with the `is_enabled/0` check in `rabbit_amqqueue:declare/7`, `rabbit_stream_manager` needs to check the callback during stream creation.
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2025
#14699) `rabbit_amqqueue:declare/7` consults the `is_enabled/0` callback of `rabbit_queue_type` before attempting to create a queue. `rabbit_stream_manager` emulates `rabbit_amqqueue:declare/7` rather than calling it directly. To align with the `is_enabled/0` check in `rabbit_amqqueue:declare/7`, `rabbit_stream_manager` needs to check the callback during stream creation. (cherry picked from commit 1c264fa)
mkuratczyk
pushed a commit
that referenced
this pull request
Oct 6, 2025
#14699) (#14701) `rabbit_amqqueue:declare/7` consults the `is_enabled/0` callback of `rabbit_queue_type` before attempting to create a queue. `rabbit_stream_manager` emulates `rabbit_amqqueue:declare/7` rather than calling it directly. To align with the `is_enabled/0` check in `rabbit_amqqueue:declare/7`, `rabbit_stream_manager` needs to check the callback during stream creation. (cherry picked from commit 1c264fa) Co-authored-by: Michael Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rabbit_amqqueue:declare/7consults theis_enabled/0callback ofrabbit_queue_typebefore attempting to create a queue.rabbit_stream_manageremulatesrabbit_amqqueue:declare/7rather than calling it directly. To align with theis_enabled/0check inrabbit_amqqueue:declare/7,rabbit_stream_managerneeds to check the callback during stream creation.This is a follow-up to #14624