Shovels bugfixes #14757
Merged
Shovels bugfixes #14757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why]
The clause above the new one in `close_sent/3` was already handling the
fact that the remote process could exit during the close "handshake".
But the remote process could terminate with `{shutdown, Reason}` in
addition to `shutdown`, where `Reason` is `delete` or `autodelete` for
instance.
[How]
We handle `{shutdown, _}` exactly as `shutdown`.
This was detected by frequent failures in CI.
michaelklishin
approved these changes
Oct 20, 2025
michaelklishin
added a commit
that referenced
this pull request
Oct 20, 2025
michaelklishin
added a commit
that referenced
this pull request
Oct 20, 2025
Shovels bugfixes (backport #14757)
michaelklishin
added a commit
that referenced
this pull request
Oct 21, 2025
(cherry picked from commit 5518a92) Conflicts: deps/rabbitmq_shovel/test/shovel_dynamic_SUITE.erl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.