rabbit_feature_flags: Reset registry after copying feature states (backport #14942) (backport #14943) #14945
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] The copy is likely to install a different list of enabled feature flags compared to the possibly loaded registry. Therefore it needs to be reset. [How] This is already the case, but the reset is done from the clustering code and not right after the copy, leaving a time frame where the feature states are inconsistent between the loaded registry and the on-disk record. This should be the responsibility of the Feature flags subsystem anyway. (cherry picked from commit 932a971) (cherry picked from commit 29c5ecb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The copy is likely to install a different list of enabled feature flags compared to the possibly loaded registry. Therefore it needs to be reset.
How
This is already the case, but the reset is done from the clustering code and not right after the copy, leaving a time frame where the feature states are inconsistent between the loaded registry and the on-disk record.
This should be the responsibility of the Feature flags subsystem anyway.
This is an automatic backport of pull request #14942 done by Mergify.
This is an automatic backport of pull request #14943 done by Mergify.