refactor(ci): Move rules workload to job

Make the rules validation first-class citizen
of the pull request and master workflows.

Author: rabbitstack

.github/workflows/pr.yml

@@ -217,3 +217,25 @@ jobs:
            export PATH="/c/msys64/mingw64/bin:$PATH"
            export PKG_CONFIG_PATH=$(pwd)/pkg-config
            ./make.bat lint
+
+  validate-rules:
+    runs-on: windows-latest
+    needs: build
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Download MSI
+        uses: actions/download-artifact@v4
+        with:
+          name: "fibratus-amd64.msi"
+          path: .
+      - name: Install MSI
+        shell: bash
+        run: |
+          ./make.bat install
+      - name: Validate rules
+        shell: bash
+        run: |
+          export PATH="/c/Program Files/Fibratus/Bin:$PATH"
+          fibratus rules list
+          fibratus rules validate

.github/workflows/rules.yml

@@ -118,7 +118,7 @@ robocopy ".\rules" "%RELEASE_DIR%\Rules" /E /S /XF *.md *.png
 
 :: Download the embedded Python distribution
 echo Downloading Python %PYTHON_VER%...
-powershell -Command "Invoke-WebRequest %PYTHON_URL% -OutFile %RELEASE_DIR%\python.zip"
+powershell -Command "Invoke-WebRequest %PYTHON_URL% -OutFile %RELEASE_DIR%\python.zip" || goto :fail
 
 echo Extracting Python distribution...
 powershell -Command "Expand-Archive %RELEASE_DIR%\python.zip -DestinationPath %RELEASE_DIR%\python"
@@ -146,9 +146,9 @@ copy %SystemRoot%\System32\dbghelp.dll "%RELEASE_DIR%\Bin"
 echo Building MSI package...
 pushd .
 cd build/msi
-wix extension add WixToolset.UI.wixext || exit /b
-wix extension add WixToolset.Util.wixext || exit /b
-wix build -ext WixToolset.UI.wixext -ext WixToolset.Util.wixext -b dir=fibratus-%VERSION% fibratus.wxs -arch x64 -d VERSION=%VERSION% -o fibratus-%VERSION%-amd64.msi || exit /b
+wix extension add WixToolset.UI.wixext || goto :fail
+wix extension add WixToolset.Util.wixext || goto :fail
+wix build -ext WixToolset.UI.wixext -ext WixToolset.Util.wixext -b dir=fibratus-%VERSION% fibratus.wxs -arch x64 -d VERSION=%VERSION% -o fibratus-%VERSION%-amd64.msi || goto :fail
 popd
 echo fibratus-%VERSION%-amd64.msi MSI package built successfully
 
@@ -180,14 +180,12 @@ copy %SystemRoot%\System32\dbghelp.dll "%RELEASE_DIR%\Bin"
 echo Building MSI package...
 pushd .
 cd build/msi
-wix extension add WixToolset.UI.wixext || exit /b
-wix extension add WixToolset.Util.wixext || exit /b
-wix build -ext WixToolset.UI.wixext -ext WixToolset.Util.wixext -b dir=fibratus-%VERSION%-slim fibratus.wxs -arch x64 -d VERSION=%VERSION% -o fibratus-%VERSION%-slim-amd64.msi || exit /b
+wix extension add WixToolset.UI.wixext || goto :fail
+wix extension add WixToolset.Util.wixext || goto :fail
+wix build -ext WixToolset.UI.wixext -ext WixToolset.Util.wixext -b dir=fibratus-%VERSION%-slim fibratus.wxs -arch x64 -d VERSION=%VERSION% -o fibratus-%VERSION%-slim-amd64.msi ||  goto :fail
 popd
 echo fibratus-%VERSION%-slim-amd64.msi MSI package built successfully
 
-if errorlevel 1 goto fail
-
 goto :EOF
 
 :clean