Skip to content

Commit b69ade4

Browse files
committed
fix(processors): Release file only by file object
The file metainfo should be removed only by file object. Doing this also by file key can lead to evicting file info that is used by subsequent events to derive the file name.
1 parent f7e8dc5 commit b69ade4

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

internal/etw/processors/fs_windows.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,10 +251,8 @@ func (f *fsProcessor) processEvent(e *kevent.Kevent) (*kevent.Kevent, error) {
251251
return ev, nil
252252
case ktypes.ReleaseFile:
253253
fileReleaseCount.Add(1)
254-
// delete both, the file object and the file key from files map
255-
fileKey := e.Kparams.MustGetUint64(kparams.FileKey)
254+
// delete file metadata by file object address
256255
fileObject := e.Kparams.MustGetUint64(kparams.FileObject)
257-
delete(f.files, fileKey)
258256
delete(f.files, fileObject)
259257
case ktypes.UnmapViewFile:
260258
_ = f.psnap.RemoveFileMapping(e.PID, e.Kparams.TryGetAddress(kparams.FileViewBase))

0 commit comments

Comments
 (0)