Allow updating nodeset inventory with failed deployment status

rabi · rabi · commit 475997cdae28 · 2025-10-14T17:24:35.000+05:30
This way new deployments can use updated inventory and as we ignore earlier failed deployments with overall deployment status, users don't have to delete the failed deployments. Jira: https://issues.redhat.com/browse/OSPRH-20821 Signed-off-by: rabi <ramishra@redhat.com>
diff --git a/controllers/dataplane/openstackdataplanenodeset_controller.go b/controllers/dataplane/openstackdataplanenodeset_controller.go
@@ -403,7 +403,7 @@ func (r *OpenStackDataPlaneNodeSetReconciler) Reconcile(ctx context.Context, req
 		return ctrl.Result{}, err
 	}
 
-	if !isDeploymentRunning && !isDeploymentFailed {
+	if !isDeploymentRunning {
 		// Generate NodeSet Inventory
 		_, err = deployment.GenerateNodeSetInventory(ctx, helper, instance,
 			allIPSets, dnsDetails.ServerAddresses, containerImages, netServiceNetMap)

Original file line number	Diff line number	Diff line change
`@@ -403,7 +403,7 @@ func (r *OpenStackDataPlaneNodeSetReconciler) Reconcile(ctx context.Context, req`
`403`	`403`	`return ctrl.Result{}, err`
`404`	`404`	`}`
`405`	`405`
`406`		`- if !isDeploymentRunning && !isDeploymentFailed {`
	`406`	`+ if !isDeploymentRunning {`
`407`	`407`	`// Generate NodeSet Inventory`
`408`	`408`	`_, err = deployment.GenerateNodeSetInventory(ctx, helper, instance,`
`409`	`409`	`allIPSets, dnsDetails.ServerAddresses, containerImages, netServiceNetMap)`