Refactor: resourses (openedx#455)

* refactor: Removed useless resources, optimized imports

* refactor: Rename drawables

Author: PavloNetrebchuk

app/src/main/java/org/openedx/app/system/push/OpenEdXFirebaseMessagingService.kt

@@ -3,7 +3,6 @@ package org.openedx.app.system.push
 import android.app.NotificationChannel
 import android.app.NotificationManager
 import android.app.PendingIntent
-import android.content.Context
 import android.content.Intent
 import android.media.RingtoneManager
 import android.os.Build
@@ -75,7 +74,7 @@ class OpenEdXFirebaseMessagingService : FirebaseMessagingService() {
             .setContentIntent(pendingIntent)
 
         val notificationManager =
-            getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
+            getSystemService(NOTIFICATION_SERVICE) as NotificationManager
 
         // Since android Oreo notification channel is needed.
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {

…p/src/main/res/drawable/splash_inset.xml …c/main/res/drawable/app_splash_inset.xmlapp/src/main/res/drawable/splash_inset.xml renamed to app/src/main/res/drawable/app_splash_inset.xml app/src/main/res/drawable/splash_inset.xml renamed to app/src/main/res/drawable/app_splash_inset.xml

@@ -1,3 +1 @@
-<resources>
-    <dimen name="fab_margin">16dp</dimen>
-</resources>
+<resources></resources>

app/src/main/res/mipmap-hdpi/ic_launcher_foreground.png

@@ -7,7 +7,7 @@
 
         <!-- Use windowSplashScreenAnimatedIcon to add either a drawable or an
              animated drawable. One of these is required. -->
-        <item name="windowSplashScreenAnimatedIcon">@drawable/splash_inset</item>
+        <item name="windowSplashScreenAnimatedIcon">@drawable/app_splash_inset</item>
         <!-- Required for animated icons -->
 
         <item name="windowSplashScreenAnimationDuration">300</item>

app/src/main/res/values/dimens.xml

@@ -1,11 +1,6 @@
 <resources>
-    <string name="action_settings">Settings</string>
-    <string name="next">Next</string>
-    <string name="previous">Previous</string>
-
     <string name="app_navigation_discovery">Discover</string>
     <string name="app_navigation_learn">Learn</string>
-    <string name="app_navigation_programs">Programs</string>
     <string name="app_navigation_profile">Profile</string>
     <string name="app_navigation_downloads">Downloads</string>
 </resources>

app/src/main/res/values/ic_launcher_background.xml

@@ -186,7 +186,7 @@ private fun RestorePasswordScreen(
             modifier = Modifier
                 .fillMaxWidth()
                 .height(200.dp),
-            painter = painterResource(id = org.openedx.core.R.drawable.core_top_header),
+            painter = painterResource(id = R.drawable.core_top_header),
             contentScale = ContentScale.FillBounds,
             contentDescription = null
         )

app/src/main/res/values/splash.xml

@@ -40,7 +40,7 @@ internal fun SocialSignedView(authType: AuthType) {
                 modifier = Modifier
                     .padding(end = 8.dp)
                     .size(20.dp),
-                painter = painterResource(id = coreR.drawable.ic_core_check),
+                painter = painterResource(id = coreR.drawable.core_ic_check),
                 tint = MaterialTheme.appColors.successBackground,
                 contentDescription = ""
             )

app/src/main/res/values/strings.xml

@@ -25,7 +25,7 @@ class BrowserAuthHelper(private val config: Config) {
             .appendQueryParameter("response_type", ApiConstants.BrowserLogin.RESPONSE_TYPE).build()
         val intent =
             CustomTabsIntent.Builder().setUrlBarHidingEnabled(true).setShowTitle(true).build()
-        intent.intent.setFlags(FLAG_ACTIVITY_NEW_TASK)
+        intent.intent.flags = FLAG_ACTIVITY_NEW_TASK
         intent.launchUrl(activityContext, uri)
     }