[POC] Try removing all dev dependencies #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

santib wants to merge 10 commits into rack:main from santib:try-removing-dev-deps

Collaborator

santib commented Dec 30, 2025

Follow-up of #706 (comment)

santib changed the title ~~Try removing all dev dependencies~~ [POC] Try removing all dev dependencies

santib force-pushed the try-removing-dev-deps branch 3 times, most recently from 3bc94cb to 8c257ba Compare

January 5, 2026 15:59

santib commented

View reviewed changes

spec/acceptance/allow2ban_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/acceptance/blocking_ip_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/acceptance/blocking_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/acceptance/blocking_subnet_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/acceptance/customizing_throttled_response_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/acceptance/fail2ban_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/acceptance/safelisting_ip_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/acceptance/safelisting_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/acceptance/safelisting_subnet_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/acceptance/throttling_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/acceptance/track_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/acceptance/track_throttle_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/allow2ban_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/fail2ban_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/rack_attack_throttle_spec.rb Outdated Show resolved Hide resolved

santib commented

View reviewed changes

spec/rack_attack_track_spec.rb Outdated Show resolved Hide resolved

grzuy reviewed

View reviewed changes

rack-attack.gemspec Outdated Show resolved Hide resolved

santib added 6 commits

January 12, 2026 10:33


          Try removing all dev dependencies

1dba0ba


          Fix tests

45d070d


          Fix Dalli3

b539ff0


          Fix ConnectionPool issue

52cde38


          Fix requires order

188f0e3


          Fix tests

67d51e1

santib force-pushed the try-removing-dev-deps branch from 4f22ea1 to 67d51e1 Compare

January 12, 2026 13:34

santib commented

View reviewed changes

spec/spec_helper.rb Outdated Show resolved Hide resolved

Fix

6bd09c8

santib added 3 commits

January 17, 2026 13:42


          Refactor

4a0611a


          Adjust connection_pool issue

cafef8d


          Use safe_require

d37279c

santib commented

View reviewed changes

Appraisals

    
              appraise "active_support_8-0_redis_cache_store" do

                gem "activesupport", "~> 8.0.0"

                # Fix connection_pool version requirement for ActiveSupport

                gem "connection_pool", "~> 2.5"

Collaborator Author

santib Jan 17, 2026

seems like it will never be fixed for ActiveSupport < 8.1

santib requested a review from grzuy

January 17, 2026 16:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet