pydantic(netapp): cleanup, update docstrings

Author: skrobul

python/understack-workflows/tests/test_netapp_value_objects.py

@@ -8,7 +8,6 @@
 from understack_workflows.netapp.value_objects import InterfaceSpec
 from understack_workflows.netapp.value_objects import NamespaceResult
 from understack_workflows.netapp.value_objects import NamespaceSpec
-from understack_workflows.netapp.value_objects import NodeResult
 from understack_workflows.netapp.value_objects import PortResult
 from understack_workflows.netapp.value_objects import PortSpec
 from understack_workflows.netapp.value_objects import RouteResult
@@ -351,6 +350,7 @@ def test_volume_result_various_states(self):
             )
             assert result.state == state
 
+
 class TestPortResult:
     """Test cases for PortResult value object."""
 
@@ -588,9 +588,9 @@ def test_calculate_destination_comprehensive_third_octet_zero(self):
 
         for ip in test_ips:
             destination = RouteSpec._calculate_destination(ip)
-            assert destination == ipaddress.IPv4Network(
-                "100.126.0.0/17"
-            ), f"Failed for IP: {ip}"
+            assert destination == ipaddress.IPv4Network("100.126.0.0/17"), (
+                f"Failed for IP: {ip}"
+            )
 
     def test_calculate_destination_comprehensive_third_octet_128(self):
         """Test comprehensive route destination calculation for third octet = 128."""
@@ -606,9 +606,9 @@ def test_calculate_destination_comprehensive_third_octet_128(self):
 
         for ip in test_ips:
             destination = RouteSpec._calculate_destination(ip)
-            assert destination == ipaddress.IPv4Network(
-                "100.126.128.0/17"
-            ), f"Failed for IP: {ip}"
+            assert destination == ipaddress.IPv4Network("100.126.128.0/17"), (
+                f"Failed for IP: {ip}"
+            )
 
     def test_calculate_destination_comprehensive_invalid_patterns(self):
         """Test comprehensive error handling for all invalid third octet values."""

python/understack-workflows/understack_workflows/main/netapp_configure_net.py

@@ -9,7 +9,6 @@
 from understack_workflows.nautobot import Nautobot
 from understack_workflows.netapp.manager import NetAppManager
 from understack_workflows.netapp.value_objects import NetappIPInterfaceConfig
-from understack_workflows.netapp.value_objects import InterfaceInfo
 from understack_workflows.netapp.value_objects import VirtualMachineNetworkInfo
 
 logger = setup_logger(__name__, level=logging.INFO)
@@ -22,7 +21,6 @@
 )
 
 
-
 def validate_and_normalize_uuid(value: str) -> str:
     """Validate that the input is a valid UUID and normalize it by removing dashes.
 

python/understack-workflows/understack_workflows/netapp/client.py

@@ -6,7 +6,6 @@
 handling low-level operations and converting between value objects and SDK objects.
 """
 
-import ipaddress
 import logging
 from abc import ABC
 from abc import abstractmethod
@@ -673,7 +672,7 @@ def create_route(self, route_spec: RouteSpec) -> RouteResult:
             result = RouteResult(
                 uuid=str(route.uuid),
                 gateway=str(route_spec.gateway),
-                destination=ipaddress.IPv4Network(str(route_spec.destination)),
+                destination=str(route_spec.destination),
                 svm_name=route_spec.svm_name,
             )