react on svm_created, not svm_enabled

- svm_enabled is a variable/output that tells if particular project is
  configured to have an SVM created in NetApp
- svm_created is a variable that records if the SVM was created in a
  particular workflow run (not that it exists or that is expected to
  exist).

This distinction allows us to gracefully react to a situation where an
end-user updates a project by adding additional tag that is not NetApp
related. Prior to this commit, this would trigger a workflow that
checks if the SVM already exists and that first part of the workflow
(oslo_event handler specifically) would terminate gracefully without a
problem. But in the next step, the ansible-to-nautobot workflow would
still get triggered even though it should not.

Author: skrobul

python/understack-workflows/understack_workflows/oslo_event/keystone_project.py

@@ -67,6 +67,7 @@ def handle_project_created(
     try:
         netapp_manager = NetAppManager()
         svm_name = _create_svm_and_volume(netapp_manager, event)
+        _save_output("svm_created", str(True))
     finally:
         if not svm_name:
             svm_name = "not_returned"
@@ -104,8 +105,12 @@ def handle_project_updated(
             )
             netapp_manager.cleanup_project(event.project_id)
         # Tag added
-        elif project_is_svm_enabled and not svm_exists:
-            svm_name = _create_svm_and_volume(netapp_manager, event)
+        elif project_is_svm_enabled:
+            if svm_exists:
+                _save_output("svm_created", str(False))
+            else:
+                svm_name = _create_svm_and_volume(netapp_manager, event)
+            _save_output("svm_created", str(True))
     finally:
         if not svm_name:
             svm_name = "not_returned"

workflows/argo-events/workflowtemplates/openstack-oslo-event.yaml

@@ -70,3 +70,6 @@ spec:
           - name: svm_enabled
             valueFrom:
               path: /var/run/argo/output.svm_enabled
+          - name: svm_created
+            valueFrom:
+              path: /var/run/argo/output.svm_created

workflows/openstack/sensors/sensor-keystone-oslo-event.yaml

@@ -95,7 +95,7 @@ spec:
                               print(str(uuid.UUID(project_id_without_dashes)))
 
                   - - name: ansible-to-nautobot
-                      when: "{{steps.oslo-events.outputs.parameters.svm_enabled}} == True"
+                      when: "{{steps.oslo-events.outputs.parameters.svm_created}} == True"
                       inline:
                         container:
                           image: ghcr.io/rss-engineering/undercloud-nautobot/ansible:latest