fix(cinder-understack): remove incorrect calls causing a crash

Remove these incorrect calls which result in a crash when a library
instance is cleaned up. Update the tests to ensure this does not happen
again.

Author: cardoe

python/cinder-understack/cinder_understack/dynamic_netapp_driver.py

@@ -238,13 +238,8 @@ def _remove_svm_lib(self, svm_name: str, svm_lib: NetAppMinimalLibrary):
         # TODO: Need to free up resources here.
         LOG.info("Removing resources for SVM library %s", svm_name)
         # Stop any looping calls if they exist
-        if svm_lib._looping_call and hasattr(svm_lib, "loopingcalls"):
+        if hasattr(svm_lib, "loopingcalls"):
             LOG.info("Stopping looping call for SVM library %s", svm_name)
-            svm_lib.loopingcalls.stop_tasks()
-            # Adding None coz it has a reference to the looping call
-            svm_lib.looping_call = None
-            # There are other attributes which are in svm_lib even after
-            # Stopping the looping.
 
     def _refresh_svm_libraries(self):
         return self._actual_refresh_svm_libraries(context.get_admin_context())

python/cinder-understack/cinder_understack/tests/test_dynamic_netapp_driver.py

@@ -10,10 +10,20 @@
 from cinder.tests.unit import utils as test_utils
 from cinder.tests.unit.volume.drivers.netapp import fakes as na_fakes
 from cinder.volume.drivers.netapp.dataontap.nvme_library import NetAppNVMeStorageLibrary
+from cinder.volume.drivers.netapp.dataontap.utils import loopingcalls
 
 from cinder_understack import dynamic_netapp_driver
 
 
+def _create_mock_svm_lib(svm_name: str):
+    mock_lib = mock.create_autospec(
+        dynamic_netapp_driver.NetAppMinimalLibrary, instance=True
+    )
+    mock_lib.vserver = svm_name
+    mock_lib.loopingcalls = loopingcalls.LoopingCalls()
+    return mock_lib
+
+
 class NetappDynamicDriverTestCase(test.TestCase):
     """Test case for NetappCinderDynamicDriver."""
 
@@ -152,21 +162,16 @@ def test_refresh_svm_libraries_adds_and_removes_svms(
         expected_svm = f"os-{self.project_id}"
 
         self.driver._libraries = {
-            "os-old-svm": mock.Mock(vserver="os-old-svm"),
-            expected_svm: mock.Mock(vserver=expected_svm),
+            "os-old-svm": _create_mock_svm_lib("os-old-svm"),
+            expected_svm: _create_mock_svm_lib(expected_svm),
         }
 
         self.driver._get_svms = mock_get_svms
         # Returned by _get_svms (after refresh)
         mock_get_svms.return_value = [expected_svm, "os-new-svm"]
 
         # make the created lib look like the real thing
-        mock_lib_instance = mock.create_autospec(
-            dynamic_netapp_driver.NetAppMinimalLibrary, instance=True
-        )
-
-        # Mock the new lib instance created
-        mock_lib_instance.vserver = "os-new-svm"
+        mock_lib_instance = _create_mock_svm_lib("os-new-svm")
         mock_create_svm_lib.return_value = mock_lib_instance
 
         # Trigger refresh