fix(create-svm): VolumeResult - NetApp returns size as integer

This is not directly related to this feature, but it's needed and I've
noticed it's broken due to pydantic being more strict about data
returned from the NetApp REST API.

Author: skrobul

python/understack-workflows/tests/test_netapp_client.py

@@ -215,7 +215,7 @@ def test_create_volume_success(self, mock_volume_class, netapp_client):
         mock_volume_instance = MagicMock()
         mock_volume_instance.name = "test-volume"
         mock_volume_instance.uuid = "volume-uuid-123"
-        mock_volume_instance.size = "1TB"
+        mock_volume_instance.size = 1024
         mock_volume_instance.state = "online"
         mock_volume_class.return_value = mock_volume_instance
 
@@ -231,7 +231,7 @@ def test_create_volume_success(self, mock_volume_class, netapp_client):
         assert isinstance(result, VolumeResult)
         assert result.name == "test-volume"
         assert result.uuid == "volume-uuid-123"
-        assert result.size == "1TB"
+        assert result.size == 1024
         assert result.state == "online"
         assert result.svm_name == "test-svm"
 

python/understack-workflows/tests/test_netapp_value_objects.py

@@ -321,21 +321,21 @@ def test_valid_volume_result(self):
         result = VolumeResult(
             name="test-volume",
             uuid="vol-uuid-123",
-            size="1TB",
+            size=1024,
             state="online",
             svm_name="test-svm",
         )
 
         assert result.name == "test-volume"
         assert result.uuid == "vol-uuid-123"
-        assert result.size == "1TB"
+        assert result.size == 1024
         assert result.state == "online"
         assert result.svm_name == "test-svm"
 
     def test_volume_result_without_svm_name(self):
         """Test volume result without SVM name."""
         result = VolumeResult(
-            name="test-volume", uuid="vol-uuid-123", size="1TB", state="online"
+            name="test-volume", uuid="vol-uuid-123", size=1024, state="online"
         )
 
         assert result.svm_name is None
@@ -346,7 +346,7 @@ def test_volume_result_various_states(self):
 
         for state in states:
             result = VolumeResult(
-                name="test-volume", uuid="vol-uuid-123", size="1TB", state=state
+                name="test-volume", uuid="vol-uuid-123", size=1024, state=state
             )
             assert result.state == state
 

python/understack-workflows/tests/test_netapp_volume_service.py

@@ -52,7 +52,7 @@ def test_create_volume_success(
         mock_client.create_volume.return_value = VolumeResult(
             name=expected_volume_name,
             uuid="volume-uuid-123",
-            size=size,
+            size=1024,
             state="online",
             svm_name=expected_svm_name,
         )
@@ -253,21 +253,20 @@ def test_volume_spec_creation(
     ):
         """Test that volume specification is created correctly."""
         project_id = "test-project-789"
-        size = "2TB"
         aggregate_name = "test-aggregate"
 
         mock_client.create_volume.return_value = VolumeResult(
-            name="vol_test-project-789", uuid="uuid-123", size=size, state="online"
+            name="vol_test-project-789", uuid="uuid-123", size=2048, state="online"
         )
 
-        volume_service.create_volume(project_id, size, aggregate_name)
+        volume_service.create_volume(project_id, "2048M", aggregate_name)
 
         # Verify the volume spec is created correctly
         call_args = mock_client.create_volume.call_args[0][0]
         assert call_args.name == "vol_test-project-789"
         assert call_args.svm_name == "os-test-project-789"
         assert call_args.aggregate_name == aggregate_name
-        assert call_args.size == size
+        assert call_args.size == "2048M"
 
     def test_namespace_spec_creation(
         self, volume_service, mock_client, mock_error_handler
@@ -304,7 +303,7 @@ def test_exists_volume_found(self, volume_service, mock_client, mock_error_handl
         mock_volume_result = VolumeResult(
             name=expected_volume_name,
             uuid="volume-uuid-123",
-            size="1TB",
+            size=1024,
             state="online",
             svm_name=expected_svm_name,
         )

python/understack-workflows/understack_workflows/netapp/client.py

@@ -352,7 +352,7 @@ def create_volume(self, volume_spec: VolumeSpec) -> VolumeResult:
             result = VolumeResult(
                 name=str(volume.name),
                 uuid=str(volume.uuid),
-                size=getattr(volume, "size", volume_spec.size),
+                size=int(getattr(volume, "size", volume_spec.size)),
                 state=getattr(volume, "state", "unknown"),
                 svm_name=volume_spec.svm_name,
             )
@@ -426,7 +426,7 @@ def find_volume(self, volume_name: str, svm_name: str) -> VolumeResult | None:
                 return VolumeResult(
                     name=str(volume.name),
                     uuid=str(volume.uuid),
-                    size=getattr(volume, "size", "unknown"),
+                    size=int(getattr(volume, "size", "unknown")),
                     state=getattr(volume, "state", "unknown"),
                     svm_name=svm_name,
                 )

python/understack-workflows/understack_workflows/netapp/value_objects.py

@@ -749,7 +749,7 @@ class VolumeResult(BaseModel):
         >>> result = VolumeResult(
         ...     name="test-vol",
         ...     uuid="12345678-1234-1234-1234-123456789abc",
-        ...     size="100GB",
+        ...     size=10024,
         ...     state="online",
         ...     svm_name="test-svm"
         ... )
@@ -759,7 +759,7 @@ class VolumeResult(BaseModel):
 
     name: str
     uuid: str
-    size: str
+    size: int
     state: str
     svm_name: str | None = None