fix: duplicate logging

Author: skrobul

python/understack-workflows/tests/test_netapp_configure_net.py

@@ -1542,8 +1542,6 @@ def test_netapp_create_interfaces_logs_interface_creation(self):
                 # Verify logging was called with correct messages
                 expected_calls = [
                     (("Creating LIF %s for project %s", "test-interface", project_id),),
-                    (("Creating routes for project %s", project_id),),
-                    (("Successfully created %d routes for project %s", 0, project_id),),
                 ]
                 mock_logger.info.assert_has_calls(expected_calls, any_order=False)
 

python/understack-workflows/tests/test_netapp_manager.py

@@ -500,49 +500,7 @@ def test_create_routes_for_project_error_handling(
             "test-project", sample_interface_configs
         )
 
-    @patch("understack_workflows.netapp.manager.config")
-    @patch("understack_workflows.netapp.manager.HostConnection")
-    def test_create_routes_for_project_logging(
-        self,
-        mock_host_connection,
-        mock_config,
-        mock_config_file,
-        sample_interface_configs,
-    ):
-        """Test create_routes_for_project logging behavior."""
-        from understack_workflows.netapp.value_objects import RouteResult
-
-        manager = NetAppManager(mock_config_file)
-
-        # Mock route service
-        expected_results = [
-            RouteResult(
-                uuid="route-uuid-1",
-                gateway="100.127.0.17",
-                destination="100.126.0.0/17",
-                svm_name="os-test-project",
-            ),
-        ]
-        manager._route_service.create_routes_from_interfaces = MagicMock(
-            return_value=expected_results
-        )
-
-        with patch("understack_workflows.netapp.manager.logger") as mock_logger:
-            result = manager.create_routes_for_project(
-                "test-project", sample_interface_configs
-            )
 
-            # Verify logging calls
-            mock_logger.info.assert_any_call(
-                "Creating routes for project %(project_id)s with %(count)d interfaces",
-                {"project_id": "test-project", "count": 3},
-            )
-            mock_logger.info.assert_any_call(
-                "Successfully created %(count)d routes for project %(project_id)s",
-                {"count": 1, "project_id": "test-project"},
-            )
-
-        assert result == expected_results
 
     @patch("understack_workflows.netapp.manager.config")
     @patch("understack_workflows.netapp.manager.HostConnection")

python/understack-workflows/tests/test_netapp_route_service.py

@@ -104,13 +104,13 @@ def test_create_routes_from_interfaces_success(
         assert isinstance(route_specs[0], RouteSpec)
         assert route_specs[0].svm_name == expected_svm_name
         assert route_specs[0].gateway in ["100.127.0.17", "100.127.128.17"]
-        assert route_specs[0].destination in ["100.126.0.0/17", "100.126.128.0/17"]
+        assert route_specs[0].destination in [ipaddress.IPv4Network("100.126.0.0/17"), ipaddress.IPv4Network("100.126.128.0/17")]
 
         # Check second route spec
         assert isinstance(route_specs[1], RouteSpec)
         assert route_specs[1].svm_name == expected_svm_name
         assert route_specs[1].gateway in ["100.127.0.17", "100.127.128.17"]
-        assert route_specs[1].destination in ["100.126.0.0/17", "100.126.128.0/17"]
+        assert route_specs[1].destination in [ipaddress.IPv4Network("100.126.0.0/17"), ipaddress.IPv4Network("100.126.128.0/17")]
 
         # Verify different gateways were used
         gateways = {spec.gateway for spec in route_specs}
@@ -169,7 +169,7 @@ def test_create_routes_from_interfaces_single_route(
         assert isinstance(call_args, RouteSpec)
         assert call_args.svm_name == expected_svm_name
         assert call_args.gateway == "100.127.0.17"
-        assert call_args.destination == "100.126.0.0/17"
+        assert call_args.destination == ipaddress.IPv4Network("100.126.0.0/17")
 
     def test_create_routes_from_interfaces_empty_list(
         self, route_service, mock_client, mock_error_handler
@@ -185,8 +185,8 @@ def test_create_routes_from_interfaces_empty_list(
         # Verify client was not called
         mock_client.create_route.assert_not_called()
 
-        # Verify logging
-        mock_error_handler.log_info.assert_called()
+        # Verify logging - no logging expected for empty list
+        mock_error_handler.log_info.assert_not_called()
 
     def test_create_routes_from_interfaces_route_creation_error(
         self, route_service, mock_client, mock_error_handler, sample_interface_configs
@@ -385,9 +385,9 @@ def test_route_spec_creation_from_nexthop(
         # Find specs by gateway to verify destinations
         for spec in route_specs:
             if spec.gateway == "100.127.0.17":
-                assert spec.destination == "100.126.0.0/17"
+                assert spec.destination == ipaddress.IPv4Network("100.126.0.0/17")
             elif spec.gateway == "100.127.128.17":
-                assert spec.destination == "100.126.128.0/17"
+                assert spec.destination == ipaddress.IPv4Network("100.126.128.0/17")
             else:
                 pytest.fail(f"Unexpected gateway: {spec.gateway}")
 
@@ -423,17 +423,15 @@ def test_logging_behavior(
         log_info_calls = mock_error_handler.log_info.call_args_list
         log_debug_calls = mock_error_handler.log_debug.call_args_list
 
-        # Should have info logs for: start, each route creation, completion
-        assert len(log_info_calls) >= 4  # start + 2 routes + completion
+        # Should have info logs for: each route creation (no start/completion logs)
+        assert len(log_info_calls) >= 2  # 2 routes created
 
         # Should have debug logs for nexthop extraction
         assert len(log_debug_calls) >= 1
 
         # Verify specific log messages
         log_messages = [call[0][0] for call in log_info_calls]
-        assert any("Creating routes for project" in msg for msg in log_messages)
         assert any("Created route:" in msg for msg in log_messages)
-        assert any("Successfully created" in msg for msg in log_messages)
 
     def test_create_routes_netapp_rest_error_handling(
         self, route_service, mock_client, mock_error_handler, sample_interface_configs

python/understack-workflows/understack_workflows/main/netapp_configure_net.py

@@ -359,18 +359,13 @@ def netapp_create_interfaces_and_routes(
         nautobot_response, mgr.config
     )
 
-    # Create LIF interfaces (existing functionality)
+    # Create LIF interfaces
     for interface_config in configs:
         logger.info("Creating LIF %s for project %s", interface_config.name, project_id)
         mgr.create_lif(project_id, interface_config)
 
-    # Create routes (new functionality)
-    logger.info("Creating routes for project %s", project_id)
-    route_results = mgr.create_routes_for_project(project_id, configs)
-
-    logger.info(
-        "Successfully created %d routes for project %s", len(route_results), project_id
-    )
+    # Create routes
+    mgr.create_routes_for_project(project_id, configs)
     return
 
 

python/understack-workflows/understack_workflows/netapp/manager.py

@@ -476,21 +476,11 @@ def create_routes_for_project(
         Raises:
             NetworkOperationError: If route creation fails
         """
-        logger.info(
-            "Creating routes for project %(project_id)s with %(count)d interfaces",
-            {"project_id": project_id, "count": len(interface_configs)},
-        )
-
         try:
             results = self._route_service.create_routes_from_interfaces(
                 project_id, interface_configs
             )
 
-            logger.info(
-                "Successfully created %(count)d routes for project %(project_id)s",
-                {"count": len(results), "project_id": project_id},
-            )
-
             return results
 
         except Exception as e:

python/understack-workflows/understack_workflows/netapp/route_service.py

@@ -45,11 +45,6 @@ def create_routes_from_interfaces(
             NetworkOperationError: If route creation fails
         """
         try:
-            self._error_handler.log_info(
-                "Creating routes for project %(project_id)s",
-                {"project_id": project_id},
-            )
-
             # Extract unique nexthop addresses
             unique_nexthops = self._extract_unique_nexthops(interface_configs)
 
@@ -89,11 +84,6 @@ def create_routes_from_interfaces(
                         },
                     )
 
-            self._error_handler.log_info(
-                "Successfully created %(count)d routes for project %(project_id)s",
-                {"count": len(results), "project_id": project_id},
-            )
-
             return results
 
         except Exception as e: