feat(nova-understack): move storage prefixes to config

Moved the storage prefix information to the configuration file instead
of being hardcoded in the code.

Author: cardoe

python/nova-understack/ironic_understack/conf.py

@@ -27,6 +27,26 @@ def setup_conf():
             help="Controls if Nova should inject storage IPs to config drive.",
             default=True,
         ),
+        cfg.StrOpt(
+            "storage_target_a_prefix",
+            help="Storage Networking Target Prefix A-side",
+            default="100.127.0.0/17",
+        ),
+        cfg.StrOpt(
+            "storage_target_b_prefix",
+            help="Storage Networking Target Prefix B-side",
+            default="100.127.128.0/17",
+        ),
+        cfg.StrOpt(
+            "storage_client_a_prefix",
+            help="Storage Networking Client Prefix A-side",
+            default="100.126.0.0/17",
+        ),
+        cfg.StrOpt(
+            "storage_client_b_prefix",
+            help="Storage Networking Client Prefix B-side",
+            default="100.126.128.0/17",
+        ),
     ]
     cfg.CONF.register_group(grp)
     cfg.CONF.register_opts(opts, group=grp)

python/nova-understack/ironic_understack/nautobot_client.py

@@ -4,6 +4,7 @@
 from uuid import UUID
 
 import requests
+from oslo_config import cfg
 
 
 @dataclass
@@ -30,10 +31,11 @@ def address(self) -> str:
     @property
     def target_network(self) -> ipaddress.IPv4Network:
         """Returns the respective target-side network."""
-        target_a_prefix = ipaddress.IPv4Network("100.127.0.0/17")
-        target_b_prefix = ipaddress.IPv4Network("100.127.128.0/17")
-        client_a_prefix = ipaddress.IPv4Network("100.126.0.0/17")
-        client_b_prefix = ipaddress.IPv4Network("100.126.128.0/17")
+        nova_us_cfg = cfg.CONF.nova_understack
+        target_a_prefix = ipaddress.IPv4Network(nova_us_cfg.storage_target_a_prefix)
+        target_b_prefix = ipaddress.IPv4Network(nova_us_cfg.storage_target_b_prefix)
+        client_a_prefix = ipaddress.IPv4Network(nova_us_cfg.storage_client_a_prefix)
+        client_b_prefix = ipaddress.IPv4Network(nova_us_cfg.storage_client_b_prefix)
 
         if self.interface.ip in client_a_prefix:
             return target_a_prefix