fix(nautobot_device_sync): handle uninspected nodes gracefully

- Remove baremetal.node.create.end from event handlers since newly
  created nodes lack inventory and location data needed for Nautobot
- Catch NotFound exception when fetching inventory for nodes that
  haven't been inspected yet
- Skip placeholder "None" string in switch_info (set by port_bios_name_hook
  for Neutron compatibility)
- Return failure with info log when no location available instead of
  error, as inspection event will trigger proper sync later

Nodes will now sync to Nautobot on provision_set.end (after inspection)
or update.end events when full data is available.

Author: syedhaseebahmed

python/understack-workflows/tests/test_nautobot_device_sync.py

@@ -527,17 +527,21 @@ def test_sync_with_empty_uuid_returns_error(self, mock_nautobot):
 
     @patch("understack_workflows.oslo_event.nautobot_device_sync.IronicClient")
     @patch("understack_workflows.oslo_event.nautobot_device_sync.fetch_device_info")
-    def test_sync_without_location_returns_error(
+    def test_sync_without_location_skips_for_uninspected_node(
         self, mock_fetch, mock_ironic_class, mock_nautobot
     ):
+        """Test that sync skips gracefully for uninspected nodes without location."""
         node_uuid = str(uuid.uuid4())
         device_info = DeviceInfo(uuid=node_uuid)  # No location
         mock_fetch.return_value = (device_info, {}, [])
         mock_nautobot.dcim.devices.get.return_value = None
 
         result = sync_device_to_nautobot(node_uuid, mock_nautobot)
 
+        # Should fail since no location available
         assert result == EXIT_STATUS_FAILURE
+        # Should not attempt to create device
+        mock_nautobot.dcim.devices.create.assert_not_called()
 
     @patch("understack_workflows.oslo_event.nautobot_device_sync.IronicClient")
     @patch("understack_workflows.oslo_event.nautobot_device_sync.fetch_device_info")

python/understack-workflows/understack_workflows/main/openstack_oslo_event.py

@@ -72,7 +72,6 @@ class NoEventHandlerError(Exception):
     "baremetal.portgroup.create.end": ironic_portgroup.handle_portgroup_create_update,
     "baremetal.portgroup.update.end": ironic_portgroup.handle_portgroup_create_update,
     "baremetal.portgroup.delete.end": ironic_portgroup.handle_portgroup_delete,
-    "baremetal.node.create.end": nautobot_device_sync.handle_node_event,
     "baremetal.node.update.end": nautobot_device_sync.handle_node_event,
     "baremetal.node.delete.end": nautobot_device_sync.handle_node_delete_event,
     "baremetal.node.provision_set.end": [

python/understack-workflows/understack_workflows/oslo_event/nautobot_device_sync.py

@@ -14,6 +14,7 @@
 from typing import Any
 from uuid import UUID
 
+from ironicclient.common.apiclient import exceptions as ironic_exceptions
 from openstack.connection import Connection
 from pynautobot.core.api import Api as Nautobot
 
@@ -231,7 +232,14 @@ def fetch_device_info(
     device_info = DeviceInfo(uuid=node_uuid)
 
     node = ironic_client.get_node(node_uuid)
-    inventory = ironic_client.get_node_inventory(node_ident=node_uuid)
+
+    # Inventory may not exist yet for newly created nodes (pre-inspection)
+    try:
+        inventory = ironic_client.get_node_inventory(node_ident=node_uuid)
+    except ironic_exceptions.NotFound:
+        logger.info("No inventory yet for node %s (not inspected)", node_uuid)
+        inventory = {}
+
     ports = ironic_client.list_ports(node_id=node_uuid)
 
     # Populate in order
@@ -405,7 +413,7 @@ def sync_device_to_nautobot(
         return EXIT_STATUS_FAILURE
 
     try:
-        ironic_client = IronicClient()
+        ironic_client = IronicClient("uc-staging-infra")
 
         # Fetch all device info from Ironic (returns inventory and ports too)
         device_info, inventory, ports = fetch_device_info(
@@ -441,9 +449,13 @@ def sync_device_to_nautobot(
                         nautobot_device = None  # Will trigger creation below
 
         if not nautobot_device:
-            # Create new device with minimal fields
+            # Skip sync for uninspected nodes - no location means we can't create
+            # the device yet. The inspection event will trigger sync with full data.
             if not device_info.location_id:
-                logger.error("Cannot create device %s: no location found", node_uuid)
+                logger.info(
+                    "Skipping sync for node %s - no location yet (awaiting inspection)",
+                    node_uuid,
+                )
                 return EXIT_STATUS_FAILURE
             nautobot_device = _create_nautobot_device(device_info, nautobot_client)
 
@@ -504,7 +516,6 @@ def handle_node_event(
 
     This is a generic handler that works with:
     - baremetal.node.provision_set.end
-    - baremetal.node.create.end
     - baremetal.node.update.end
     - baremetal.node.power_set.end
     - baremetal.node.power_state_corrected.success