Merge pull request #1379 from rackerlabs/dnsmasq-snponly

fix(ironic): add snponly.efi to the tftp server

Author: cardoe

.github/workflows/containers.yaml

@@ -111,7 +111,7 @@ jobs:
         with:
           context: "{{defaultContext}}:containers/dnsmasq"
           file: Dockerfile
-          push: ${{ github.event_name != 'pull_request' }}
+          push: true
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
 

components/ironic/dnsmasq-ss.yaml

@@ -78,9 +78,6 @@ spec:
               mountPath: /etc/dnsmasq.d
             - name: pod-dhcp
               mountPath: /var/lib/misc
-            - name: understack-data
-              mountPath: /var/lib/understack/
-              readOnly: true
       volumes:
         - name: pod-tmp
           emptyDir: {}
@@ -90,6 +87,3 @@ spec:
         - name: pod-dhcp
           persistentVolumeClaim:
             claimName: dnsmasq-dhcp
-        - name: understack-data
-          persistentVolumeClaim:
-            claimName: understack-data

components/ironic/kustomization.yaml

@@ -7,7 +7,6 @@ resources:
   - ironic-rabbitmq-queue.yaml
   - dnsmasq-pvc.yaml
   - dnsmasq-ss.yaml
-  - understack-data-pvc.yaml
   - ironic-ks-user-baremetal.yaml
   # less than ideal addition but necessary so that we can have the ironic.conf.d loading
   # working due to the way the chart hardcodes the config-file parameter which then

components/ironic/understack-data-pvc.yaml

@@ -215,8 +215,6 @@ pod:
             mountPath: /etc/dnsmasq.d/
           - name: dnsmasq-dhcp
             mountPath: /var/lib/dnsmasq/
-          - name: understack-data
-            mountPath: /var/lib/understack
           - name: device-types
             mountPath: /var/lib/understack/device-types
           - name: ironic-etc-snippets
@@ -229,9 +227,6 @@ pod:
           - name: dnsmasq-dhcp
             persistentVolumeClaim:
               claimName: dnsmasq-dhcp
-          - name: understack-data
-            persistentVolumeClaim:
-              claimName: understack-data
           - name: device-types
             configMap:
               name: device-types

components/ironic/values.yaml

@@ -16,6 +16,7 @@ RUN apt-get update && apt-get -y install \
     pkg-config \
     ca-certificates \
     quilt \
+    ipxe \
     --no-install-recommends
 WORKDIR /src
 RUN apt-get -y build-dep dnsmasq
@@ -42,11 +43,14 @@ COPY --from=builder /src/dnsmasq-base_*_amd64.deb /tmp
 COPY --from=builder /src/dnsmasq_*_all.deb /tmp
 
 RUN apt-get update && \
-    apt-get -y install --no-install-recommends python3-jinja2 && \
+    apt-get -y install --no-install-recommends python3-jinja2 ipxe && \
     apt-get -y --fix-broken install --no-install-recommends /tmp/dnsmasq-base_*_amd64.deb /tmp/dnsmasq_*_all.deb && \
     apt-get clean && \
     rm -rf /var/lib/apt/lists/* /tmp/*.deb
 
+RUN mkdir -p /var/lib/openstack-helm/tftpboot && \
+    cp /usr/lib/ipxe/snponly.efi /var/lib/openstack-helm/tftpboot/
+
 COPY common/helpers.sh /helpers.sh
 COPY dnsmasq/entry-point.sh /entry-point.sh
 RUN chmod +x /entry-point.sh