add check if segment is dynamic before deleting

Author: Milan Fencik

python/neutron-understack/neutron_understack/neutron_understack_mech.py

@@ -268,7 +268,9 @@ def _tenant_network_port_cleanup(self, context: PortContext):
             original_binding, self.nb
         )
 
-        if not utils.ports_bound_to_segment(segment_id):
+        if not utils.ports_bound_to_segment(
+            segment_id
+        ) and utils.is_dynamic_network_segment(segment_id):
             context.release_dynamic_segment(segment_id)
             self.nb.delete_vlan(segment_id)
 

python/neutron-understack/neutron_understack/trunk.py

@@ -250,7 +250,9 @@ def _delete_binding_level(self, port_id: str, host: str) -> PortBindingLevel:
 
     def _delete_unused_segment(self, segment_id: str) -> NetworkSegment:
         network_segment = utils.network_segment_by_id(segment_id)
-        if not utils.ports_bound_to_segment(segment_id):
+        if not utils.ports_bound_to_segment(
+            segment_id
+        ) and utils.is_dynamic_network_segment(segment_id):
             utils.release_dynamic_segment(segment_id)
             self.nb.delete_vlan(vlan_id=segment_id)
         return network_segment

python/neutron-understack/neutron_understack/utils.py

@@ -105,6 +105,11 @@ def release_dynamic_segment(segment_id: str) -> None:
         core_plugin.type_manager.release_dynamic_segment(context, segment_id)
 
 
+def is_dynamic_network_segment(segment_id: str) -> bool:
+    segment = network_segment_by_id(segment_id)
+    return segment.is_dynamic
+
+
 def fetch_connected_interface_uuid(binding_profile: dict, nautobot: Nautobot) -> str:
     """Fetches the connected interface UUID from the port's binding profile.