imageservice: Fix members unit tests

We need to:

1) Specify that our returned payload is a JSON one
2) Return a dumb payload when returning a POST error or else
client.Request() tries to unmarshal a nil payload. We will send a
further path to fix client.Request() to not expect a POST response
payload for certain status codes.

Signed-off-by: Samuel Ortiz <[email protected]>

Author: Samuel Ortiz

openstack/imageservice/v2/members/fixtures.go

@@ -38,6 +38,8 @@ func HandleCreateImageMemberInvalidVisibility(t *testing.T) {
 
 		th.TestJSONRequest(t, r, `{"member": "8989447062e04a818baf9e073fd04fa7"}`)
 		w.WriteHeader(http.StatusForbidden)
+		w.Header().Add("Content-Type", "application/json")
+		fmt.Fprintf(w, `{"members":[]}`)
 	})
 
 }
@@ -51,6 +53,8 @@ func HandleCreateImageMemberConflict(t *testing.T) {
 		th.TestJSONRequest(t, r, `{"member": "8989447062e04a818baf9e073fd04fa7"}`)
 
 		w.WriteHeader(http.StatusConflict)
+		w.Header().Add("Content-Type", "application/json")
+		fmt.Fprintf(w, `{"members":[]}`)
 	})
 }
 
@@ -60,7 +64,7 @@ func HandleImageMemberList(t *testing.T) {
 		th.TestMethod(t, r, "GET")
 		th.TestHeader(t, r, "X-Auth-Token", fakeclient.TokenID)
 
-		w.WriteHeader(http.StatusOK)
+		w.Header().Add("Content-Type", "application/json")
 		fmt.Fprintf(w, `{
 		    "members": [
 		        {
@@ -91,7 +95,7 @@ func HandleImageMemberEmptyList(t *testing.T) {
 		th.TestMethod(t, r, "GET")
 		th.TestHeader(t, r, "X-Auth-Token", fakeclient.TokenID)
 
-		w.WriteHeader(http.StatusOK)
+		w.Header().Add("Content-Type", "application/json")
 		fmt.Fprintf(w, `{
 		    "members": [],
 		    "schema": "/v2/schemas/members"