failing implementation of Create

Author: James Fisher

openstack/imageservice/v2/requests.go

@@ -1,3 +1,162 @@
 package v2
 
-// TODO
+import (
+	"github.com/rackspace/gophercloud"
+	//"github.com/rackspace/gophercloud/pagination"
+)
+
+// List : (*gophercloud.ServiceClient) -> pagination.Pager<ImagePage>
+// func List(c *gophercloud.ServiceClient) pagination.Pager {
+// 	return pagination.NewPager(c, listURL(c), func (r pagination.PageResult) pagination.Page {
+// 		p := ImagePage{pagination.MarkerPageBase{PageResult: r}}
+// 		p.MarkerPageBase.Owner = p
+// 		return p
+// 	})
+// }
+
+func Create(client *gophercloud.ServiceClient, opts CreateOptsBuilder) CreateResult {
+	var res CreateResult
+	body, err := opts.ToImageCreateMap()
+	if err != nil {
+		res.Err = err
+		return res
+	}
+	response, err := client.Post(createURL(client), body, &res.Body, nil)
+	// TODO check response..?
+	return res
+}
+
+// CreateOptsBuilder describes struct types that can be accepted by the Create call.
+// The CreateOpts struct in this package does.
+type CreateOptsBuilder interface {
+	// Returns value that implements json.Marshaler
+	ToImageCreateMap() (map[string]interface{}, error)
+}
+
+// implements CreateOptsBuilder
+type CreateOpts struct {
+	// Name [required] is the name of the new image.
+	Name string
+
+	// Id [optional] is the the image ID.
+	Id string
+
+	// Visibility [optional] defines who can see/use the image.
+	Visibility ImageVisibility
+
+	// Tags [optional] is a set of image tags.
+	Tags []string
+
+	// ContainerFormat [optional] is the format of the
+	// container. Valid values are ami, ari, aki, bare, and ovf.
+	ContainerFormat string
+
+	// DiskFormat [optional] is the format of the disk. If set,
+	// valid values are ami, ari, aki, vhd, vmdk, raw, qcow2, vdi,
+	// and iso.
+	DiskFormat string
+
+	// MinDiskGigabytes [optional] is the amount of disk space in
+	// GB that is required to boot the image.
+	MinDiskGigabytes int
+
+	// MinRamMegabytes [optional] is the amount of RAM in MB that
+	// is required to boot the image.
+	MinRamMegabytes int
+
+	// protected [optional] is whether the image is not deletable.
+	Protected bool
+
+	// properties [optional] is a set of properties, if any, that
+	// are associated with the image.
+	Properties map[string]string
+}
+
+func setIfNotNil(m map[string]interface{}, k string, v interface{}) {
+	if v != nil {
+		m[k] = v
+	}
+}
+
+// ToImageCreateMap assembles a request body based on the contents of
+// a CreateOpts.
+func (opts CreateOpts) ToImageCreateMap() (map[string]interface{}, error) {
+	body := map[string]interface{}{}
+	body["name"] = opts.Name
+	setIfNotNil(body, "id", opts.Id)
+	setIfNotNil(body, "visibility", opts.Visibility)
+	setIfNotNil(body, "tags", opts.Tags)
+	setIfNotNil(body, "container_format", opts.ContainerFormat)
+	setIfNotNil(body, "disk_format", opts.DiskFormat)
+	setIfNotNil(body, "min_disk", opts.MinDiskGigabytes)
+	setIfNotNil(body, "min_ram", opts.MinRamMegabytes)
+	setIfNotNil(body, "protected", opts.Protected)
+	setIfNotNil(body, "properties", opts.Properties)
+	return body, nil
+}
+
+func Delete(client *gophercloud.ServiceClient, id string) DeleteResult {
+	var res DeleteResult
+	_, res.Err = client.Delete(deleteURL(client, id), nil)
+	return res
+}
+
+func Get(client *gophercloud.ServiceClient, id string) GetResult {
+	var res GetResult
+	client.Get(getURL(client, id), &res.Body, nil)
+	return res
+}
+
+func Update(client *gophercloud.ServiceClient, id string, opts UpdateOptsBuilder) UpdateResult {
+	var res UpdateResult
+	reqBody := opts.ToImageUpdateMap()
+
+	_, res.Err = client.Patch(updateURL(client, id), reqBody, &res.Body, &gophercloud.RequestOpts{
+		OkCodes: []int{200},
+	})
+	return res
+}
+
+type UpdateOptsBuilder interface {
+	// returns value implementing json.Marshaler which when marshaled matches the patch schema:
+	// http://specs.openstack.org/openstack/glance-specs/specs/api/v2/http-patch-image-api-v2.html
+	ToImageUpdateMap() []interface{}
+}
+
+// implements UpdateOptsBuilder
+type UpdateOpts []Patch
+
+func (opts UpdateOpts) ToImageUpdateMap() []interface{} {
+	m := make([]interface{}, len(opts))
+	for i, patch := range opts {
+		patchJson := patch.ToImagePatchMap()
+		m[i] = patchJson
+	}
+	return m
+}
+
+// Patch represents a single update to an existing image. Multiple updates to an image can be
+// submitted at the same time.
+type Patch interface {
+	ToImagePatchMap() map[string]interface{}
+}
+
+//implements Patch
+type ReplaceImageName struct {
+	NewName string
+}
+
+func (r *ReplaceImageName) ToImagePatchMap() map[string]interface{} {
+	m := map[string]interface{}{}
+	m["op"] = "replace"
+	m["path"] = "/name"
+	m["value"] = r.NewName
+	return m
+}
+
+// Things implementing Patch can also implement UpdateOptsBuilder.
+// Unfortunately we have to specify each of these manually.
+
+func (r *ReplaceImageName) ToImageUpdateMap() map[string]interface{} {
+	return r.ToImagePatchMap()
+}

openstack/imageservice/v2/results.go

@@ -0,0 +1,80 @@
+package v2
+
+import (
+	"github.com/rackspace/gophercloud"
+	//"github.com/rackspace/gophercloud/pagination"
+
+	"github.com/mitchellh/mapstructure"
+)
+
+// does not include the literal image data; just metadata.
+// returned by listing images, and by fetching a specific image.
+type Image struct {
+	Id string `mapstructure:"id"`
+	
+	Name string `mapstructure:"name"`
+	
+	Status ImageStatus `mapstructure:"status"`
+	
+	Tags []string `mapstructure:"tags"`
+	
+	ContainerFormat string `mapstructure:"container_format"`
+	DiskFormat string `mapstructure:"disk_format"`
+	
+	MinDiskGigabytes int `mapstructure:"min_disk"`
+	MinRamMegabytes int `mapstructure:"min_ram"`
+	
+	Owner string `mapstructure:"owner"`
+	
+	Protected bool `mapstructure:"protected"`
+	Visibility ImageVisibility `mapstructure:"visibility"`
+
+	Checksum string `mapstructure:"checksum"`
+	SizeBytes int `mapstructure:"size"`
+	
+	Metadata map[string]string `mapstructure:"metadata"`
+	Properties map[string]string `mapstructure:"properties"`
+}
+
+// implements pagination.Page<Image>, pagination.MarkerPage
+// DOESN'T implement Page. Why? How does openstack/compute/v2
+// type ImagePage struct {
+// 	pagination.MarkerPageBase  // pagination.MarkerPageBase<Image>
+// }
+
+type CreateResult struct {
+	gophercloud.ErrResult
+}
+
+// The response to `POST /images` follows the same schema as `GET /images/:id`.
+func extractImage(res gophercloud.ErrResult) (*Image, error) {
+	if res.Err != nil {
+		return nil, res.Err
+	}
+
+	var image Image
+
+	err := mapstructure.Decode(res.Body, &image)
+	
+	return &image, err
+}
+
+func (c CreateResult) Extract() (*Image, error) {
+	return extractImage(c.ErrResult)
+}
+
+type DeleteResult struct {
+	gophercloud.ErrResult
+}
+
+type GetResult struct {
+	gophercloud.ErrResult
+}
+
+func (c GetResult) Extract() (*Image, error) {
+	return extractImage(c.ErrResult)
+}
+
+type UpdateResult struct {
+	gophercloud.ErrResult
+}

openstack/imageservice/v2/types.go

@@ -0,0 +1,13 @@
+package v2
+
+type ImageStatus string
+const (
+	ImageStatusActive ImageStatus = "active"
+	// TODO
+)
+
+type ImageVisibility string
+const (
+	ImageVisibilityPublic ImageVisibility = "public"
+	ImageVisibilityPrivate ImageVisibility = "private"
+)