Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Commit 6a4dac0

Browse files
committed
Merge pull request #455 from jrperritt/object-create-bug-fix
one more 'object create' bug fix
2 parents 85eff9a + 9ad9243 commit 6a4dac0

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

openstack/objectstorage/v1/objects/requests.go

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -229,19 +229,18 @@ func Create(c *gophercloud.ServiceClient, containerName, objectName string, cont
229229
MoreHeaders: h,
230230
}
231231

232-
for i := 1; i <= 3; i++ {
233-
resp, err := c.Request("PUT", url, ropts)
234-
if resp != nil {
235-
res.Header = resp.Header
236-
if resp.Header.Get("ETag") == fmt.Sprintf("%x", localChecksum) {
237-
res.Err = err
238-
break
239-
}
240-
}
241-
if i == 3 {
242-
res.Err = fmt.Errorf("Local checksum does not match API ETag header")
232+
resp, err := c.Request("PUT", url, ropts)
233+
if err != nil {
234+
res.Err = err
235+
return res
236+
}
237+
if resp != nil {
238+
res.Header = resp.Header
239+
if resp.Header.Get("ETag") == fmt.Sprintf("%x", localChecksum) {
240+
res.Err = err
243241
return res
244242
}
243+
res.Err = fmt.Errorf("Local checksum does not match API ETag header")
245244
}
246245

247246
return res

0 commit comments

Comments
 (0)