Fix #107 MissingNewLineAtEndOfFileCheck should skip empty files

Author: racodond

css-checks/src/main/java/org/sonar/css/checks/common/MissingNewLineAtEndOfFileCheck.java

@@ -42,7 +42,7 @@ public class MissingNewLineAtEndOfFileCheck extends DoubleDispatchVisitorCheck {
   @Override
   public void visitStyleSheet(StyleSheetTree tree) {
     try (RandomAccessFile randomAccessFile = new RandomAccessFile(getContext().getFile(), "r")) {
-      if (!endsWithNewline(randomAccessFile)) {
+      if (!endsWithNewline(randomAccessFile) && !tree.all().isEmpty()) {
         addFileIssue("Add an empty new line at the end of this file.");
       }
     } catch (IOException e) {

css-checks/src/main/resources/org/sonar/css/checks/l10n/common/empty-line-end-of-file.html

@@ -9,6 +9,8 @@
 </pre>
 <p>if the empty line is missing at the end of the file.</p>
 
+<p>Note that empty files are not checked against this rule.</p>
+
 <h2>stylelint Related Rules</h2>
 <ul>
   <li><a href="https://stylelint.io/user-guide/rules/no-missing-end-of-source-newline/" target="_blank">no-missing-end-of-source-newline</a></li>

css-checks/src/test/java/org/sonar/css/checks/common/MissingNewLineAtEndOfFileCheckTest.java

@@ -23,19 +23,33 @@
 import org.sonar.css.checks.CheckTestUtils;
 import org.sonar.css.checks.verifier.CssCheckVerifier;
 
+import java.io.File;
+
 public class MissingNewLineAtEndOfFileCheckTest {
 
+  private MissingNewLineAtEndOfFileCheck check = new MissingNewLineAtEndOfFileCheck();
+
   @Test
   public void should_have_an_empty_new_line_at_the_end_of_the_file_and_not_raise_any_issue() {
-    CssCheckVerifier.issuesOnCssFile(new MissingNewLineAtEndOfFileCheck(), CheckTestUtils.getCommonTestFile("newLineEndOfFile.css"))
+    CssCheckVerifier.issuesOnCssFile(check, getTestFile("newLineEndOfFile.css"))
       .noMore();
   }
 
   @Test
   public void should_not_have_an_empty_new_line_at_the_end_of_the_file_and_raise_an_issue() {
-    CssCheckVerifier.issuesOnCssFile(new MissingNewLineAtEndOfFileCheck(), CheckTestUtils.getCommonTestFile("noNewLineEndOfFile.css"))
+    CssCheckVerifier.issuesOnCssFile(check, getTestFile("noNewLineEndOfFile.css"))
       .next().withMessage("Add an empty new line at the end of this file.")
       .noMore();
   }
 
+  @Test
+  public void should_not_raise_any_issue_on_empty_file() {
+    CssCheckVerifier.issuesOnCssFile(check, getTestFile("noNewLineEndOfEmptyFile.css"))
+      .noMore();
+  }
+
+  private File getTestFile(String fileName) {
+    return CheckTestUtils.getCommonTestFile("empty-line-end-of-file/" + fileName);
+  }
+
 }

css-checks/src/test/resources/checks/common/newLineEndOfFile.css renamed to css-checks/src/test/resources/checks/common/empty-line-end-of-file/newLineEndOfFile.css

@@ -2,10 +2,7 @@
 'project:custom/common/comment-regular-expression/commentRegularExpression.css':[
 0,
 ],
-'project:custom/common/empty-stylesheet/emptyStylesheet.css':[
-0,
-],
-'project:custom/common/empty-stylesheet/emptyStylesheetNoComment.css':[
+'project:custom/common/empty-line-end-of-file/noNewLineEndOfFile.css':[
 0,
 ],
 'project:custom/common/lineLength.css':[
@@ -20,9 +17,6 @@
 'project:custom/common/noDuplication.css':[
 0,
 ],
-'project:custom/common/noNewLineEndOfFile.css':[
-0,
-],
 'project:custom/common/properties/css/alignment-baseline.css':[
 0,
 ],