Skip to content

Commit a429150

Browse files
author
david-cooke
authored
Merge pull request #149 from ractf/hotfix/ordering
Add OrderingFilter to TeamViewSet & MemberViewSet
2 parents 3101bb3 + c51fdb6 commit a429150

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/member/views.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,9 @@ class MemberViewSet(AdminListModelViewSet):
5151
admin_serializer_class = AdminMemberSerializer
5252
list_serializer_class = ListMemberSerializer
5353
list_admin_serializer_class = ListMemberSerializer
54-
search_fields = ["username", "email"]
55-
filter_backends = [filters.SearchFilter]
54+
search_fields = ["username"]
55+
ordering_fields = ["username", "team__name"]
56+
filter_backends = [filters.SearchFilter, filters.OrderingFilter]
5657

5758
def get_queryset(self):
5859
if self.action != "list":

src/team/views.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ class TeamViewSet(AdminListModelViewSet):
6363
list_serializer_class = ListTeamSerializer
6464
list_admin_serializer_class = ListTeamSerializer
6565
search_fields = ["name"]
66-
filter_backends = [filters.SearchFilter]
66+
ordering_fields = ["name", "members__count"]
67+
filter_backends = [filters.SearchFilter, filters.OrderingFilter]
6768

6869
def get_queryset(self):
6970
if self.action == "list":

0 commit comments

Comments
 (0)