Release 6.0.7

* Indent the whole codebase
* Do not install the clang-format-radare2 script in dist iaito
* Add the dummy assert for windows

Author: radare

.github/workflows/ci.yml

@@ -1,7 +1,7 @@
 name: iaito CI
 
 env:
-  R2V: 6.0.4
+  R2V: 6.0.7
   QT_MAC_INSTALL_VERSION: 6.9.*
   QT_WIN_INSTALL_VERSION: 6.8.*
 

dist/macos/scripts/embed-radare2.sh

@@ -10,6 +10,9 @@ R2V=$(readlink "${R2DIR}/lib/radare2/last")
 fix_binary() {
   FILE=$1
   PREFIX=$2
+  if [ -n "`echo ${FILE} | grep clang-format-radare2`" ]; then
+    return
+  fi
   shift 2
   echo "Change library paths for \"$FILE\"..."
   ARGS=$(otool -L "$FILE" | awk 'BEGIN{ORS=" "}/\/usr\/local\/lib\/libr_/{dst=$1; sub(/\/usr\/local\/lib/,"'"$PREFIX"'", dst); print "-change "$1" "dst}')

src/assert.h

@@ -0,0 +1,6 @@
+#ifndef CUSTOM_ASSERT_H
+#define CUSTOM_ASSERT_H 1
+
+#define assert(x) if ((x)) {}
+
+#endif

src/common/PythonManager.cpp

@@ -1,6 +1,5 @@
 #ifdef IAITO_ENABLE_PYTHON
 
-#include <cassert>
 
 #include "Iaito.h"
 #include "PythonAPI.h"
@@ -176,7 +175,6 @@ void PythonManager::restoreThread()
 void PythonManager::saveThread()
 {
     pyThreadStateCounter--;
-    assert(pyThreadStateCounter >= 0);
     if (pyThreadStateCounter == 0) {
         pyThreadState = PyEval_SaveThread();
     }

src/common/R2Task.cpp

@@ -6,7 +6,7 @@ R2Task::R2Task(const QString &cmd, bool transient)
     task = r_core_task_new(
         Core()->core(),
 #if R2_VERSION_NUMBER >= 60005
-       	R_CORE_TASK_MODE_THREAD,
+        R_CORE_TASK_MODE_THREAD,
 #endif
         true,
         cmd.toLocal8Bit().constData(),
@@ -49,7 +49,7 @@ void R2Task::startTask()
 void R2Task::breakTask()
 {
     if (task) {
-//        r_core_task_break(&Core()->core_->tasks, task->id);
+        //        r_core_task_break(&Core()->core_->tasks, task->id);
     }
 }
 

src/common/TempConfig.cpp

@@ -1,6 +1,4 @@
 
-#include <cassert>
-
 #include "TempConfig.h"
 #include "core/Iaito.h"
 
@@ -29,7 +27,6 @@ TempConfig::~TempConfig()
             Core()->setConfig(i.key(), i.value().toBool());
             break;
         default:
-            assert(false);
             break;
         }
     }

src/core/Iaito.cpp

@@ -9,7 +9,6 @@
 #include <QStringList>
 #include <QVector>
 
-#include <cassert>
 #include <cstring>
 #include <memory>
 
@@ -172,7 +171,6 @@ RCoreLocked::RCoreLocked(IaitoCore *core)
 {
     core->coreMutex.lock();
 #if R2_VERSION_NUMBER < 50609
-    assert(core->coreLockDepth >= 0);
     core->coreLockDepth++;
     if (core->coreLockDepth == 1) {
         if (core->coreBed) {
@@ -187,7 +185,6 @@ RCoreLocked::~RCoreLocked()
 {
     core->coreLockDepth--;
 #if R2_VERSION_NUMBER < 50609
-    assert(core->coreLockDepth >= 0);
     if (core->coreLockDepth == 0) {
 #if R2_VERSION_NUMBER >= 50909
         core->coreBed = r_cons_sleep_begin(core->core_->cons);

src/core/MainWindow.h

@@ -294,10 +294,10 @@ private slots:
     NewFileDialog *newFileDialog = nullptr;
     IaitoDockWidget *breakpointDock = nullptr;
     IaitoDockWidget *registerRefsDock = nullptr;
-    MapsWidget *mapsDock = nullptr;         // RIO map manager
-    FilesWidget *filesDock = nullptr;       // IO files manager
+    MapsWidget *mapsDock = nullptr;             // RIO map manager
+    FilesWidget *filesDock = nullptr;           // IO files manager
     FilesystemWidget *filesystemDock = nullptr; // Filesystem mount manager
-    BinariesWidget *binariesDock = nullptr; // IO binaries manager
+    BinariesWidget *binariesDock = nullptr;     // IO binaries manager
     R2GraphWidget *r2GraphDock = nullptr;
     CallGraphWidget *callGraphDock = nullptr;
     CallGraphWidget *globalCallGraphDock = nullptr;

src/core/assert.h

@@ -0,0 +1,6 @@
+#ifndef CUSTOM_ASSERT_H
+#define CUSTOM_ASSERT_H 1
+
+#define assert(x) if ((x)) {}
+
+#endif

src/menus/DisassemblyContextMenu.cpp

@@ -1017,7 +1017,7 @@ void DisassemblyContextMenu::on_actionRename_triggered()
         break;
     default:
         qWarning() << "Unhandled renaming action: " << doRenameAction;
-        assert(false);
+        // assert(false);
         break;
     }