Skip to content

Commit 6448a18

Browse files
committed
Sanitize filesystem paths before r2 command execution
1 parent ce04d65 commit 6448a18

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/widgets/FilesystemWidget.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#include "FilesystemWidget.h"
22
#include "common/Helpers.h"
3+
#include "core/Iaito.h"
34
#include "core/MainWindow.h"
45
#include <QContextMenuEvent>
56
#include <QInputDialog>
@@ -29,7 +30,8 @@ void FilesystemTreeModel::refresh()
2930

3031
QJsonDocument FilesystemTreeModel::parseMdCommand(const QString &path)
3132
{
32-
QString output = Core()->cmdRaw(QString("mdj %1").arg(path));
33+
QString sanitizedPath = IaitoCore::sanitizeStringForCommand(path);
34+
QString output = Core()->cmdRaw(QString("mdj %1").arg(sanitizedPath));
3335
QJsonParseError error;
3436
QJsonDocument doc = QJsonDocument::fromJson(output.toUtf8(), &error);
3537
if (error.error != QJsonParseError::NoError) {
@@ -413,7 +415,8 @@ void FilesystemWidget::onTreeContextMenu(const QPoint &pos)
413415

414416
void FilesystemWidget::viewFileContents(const QString &path)
415417
{
416-
QString cmd = QString("mc %1").arg(path);
418+
QString sanitizedPath = IaitoCore::sanitizeStringForCommand(path);
419+
QString cmd = QString("mc %1").arg(sanitizedPath);
417420
QString output = Core()->cmdRaw(cmd.toUtf8().constData());
418421
if (!output.isEmpty()) {
419422
QMessageBox::information(this, tr("File Contents"), output);
@@ -432,7 +435,8 @@ void FilesystemWidget::deleteFile(const QString &path)
432435

433436
void FilesystemWidget::loadIntoMalloc(const QString &path)
434437
{
435-
QString cmd = QString("mo %1").arg(path);
438+
QString sanitizedPath = IaitoCore::sanitizeStringForCommand(path);
439+
QString cmd = QString("mo %1").arg(sanitizedPath);
436440
Core()->cmdRaw(cmd.toUtf8().constData());
437441
QMessageBox::information(this, tr("Success"), tr("File loaded into malloc."));
438-
}
442+
}

0 commit comments

Comments
 (0)