Fix stm8 pseudo return ##decompiler

radare · trufae · commit 44a23da3787e · 2024-09-10T12:57:20.000+02:00
diff --git a/libr/core/disasm.c b/libr/core/disasm.c
@@ -1208,8 +1208,10 @@ static void ds_build_op_str(RDisasmState *ds, bool print_color) {
 		}
 		if (ds->pseudo) {
 			if (r_parse_parse (core->parser, ds->opstr, ds->str)) {
-				free (ds->opstr);
-				ds->opstr = strdup (ds->str);
+				if (R_STR_ISNOTEMPTY (ds->str)) {
+					free (ds->opstr);
+					ds->opstr = strdup (ds->str);
+				}
 			}
 		}
 		if (ds->subjmp) {

Original file line number	Diff line number	Diff line change
`@@ -1208,8 +1208,10 @@ static void ds_build_op_str(RDisasmState *ds, bool print_color) {`
`1208`	`1208`	`}`
`1209`	`1209`	`if (ds->pseudo) {`
`1210`	`1210`	`if (r_parse_parse (core->parser, ds->opstr, ds->str)) {`
`1211`		`- free (ds->opstr);`
`1212`		`- ds->opstr = strdup (ds->str);`
	`1211`	`+ if (R_STR_ISNOTEMPTY (ds->str)) {`
	`1212`	`+ free (ds->opstr);`
	`1213`	`+ ds->opstr = strdup (ds->str);`
	`1214`	`+ }`
`1213`	`1215`	`}`
`1214`	`1216`	`}`
`1215`	`1217`	`if (ds->subjmp) {`