Skip to content

Commit d042ce3

Browse files
committed
Simplify shared build config.
1 parent cd4c416 commit d042ce3

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

.github/workflows/wheels-dependencies.sh

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ function build_libavif {
191191
fi
192192

193193
local build_type=MinSizeRel
194+
local build_shared=ON
194195
local lto=ON
195196

196197
local libavif_cmake_flags
@@ -202,20 +203,14 @@ function build_libavif {
202203
-DCMAKE_CXX_FLAGS_MINSIZEREL="-Oz -DNDEBUG -flto" \
203204
-DCMAKE_SHARED_LINKER_FLAGS_INIT="-Wl,-S,-x,-dead_strip_dylibs" \
204205
)
205-
if [[ -z "$IOS_SDK" ]]; then
206-
libavif_cmake_flags=(
207-
"${libavif_cmake_flags[@]}" \
208-
-DBUILD_SHARED_LIBS=ON
209-
)
206+
if [[ -n "$IOS_SDK" ]]; then
207+
build_shared=OFF
210208
fi
211209
else
212210
if [[ "$MB_ML_VER" == 2014 ]] && [[ "$PLAT" == "x86_64" ]]; then
213211
build_type=Release
214212
fi
215-
libavif_cmake_flags=(
216-
-DCMAKE_SHARED_LINKER_FLAGS_INIT="-Wl,--strip-all,-z,relro,-z,now" \
217-
-DBUILD_SHARED_LIBS=ON \
218-
)
213+
libavif_cmake_flags=(-DCMAKE_SHARED_LINKER_FLAGS_INIT="-Wl,--strip-all,-z,relro,-z,now")
219214
fi
220215

221216
local out_dir=$(fetch_unpack https://github.com/AOMediaCodec/libavif/archive/refs/tags/v$LIBAVIF_VERSION.tar.gz libavif-$LIBAVIF_VERSION.tar.gz)
@@ -227,6 +222,7 @@ function build_libavif {
227222
-DCMAKE_INSTALL_PREFIX=$BUILD_PREFIX \
228223
-DCMAKE_INSTALL_LIBDIR=$BUILD_PREFIX/lib \
229224
-DCMAKE_INSTALL_NAME_DIR=$BUILD_PREFIX/lib \
225+
-DBUILD_SHARED_LIBS=$build_shared \
230226
-DAVIF_LIBSHARPYUV=LOCAL \
231227
-DAVIF_LIBYUV=LOCAL \
232228
-DAVIF_CODEC_AOM=LOCAL \

0 commit comments

Comments
 (0)