Asset URL encoding of "space" character

[drandyziegler]

While the asset part in the STAC Item json looks like this

assets": {
    "latest_data": {
      "href": ["http://hilltop.gw.govt.nz/data.hts?Service=Hilltop&Request=GetData&Site=Abbots%20Creek%20at%20Featherston&Measurement=Daily%20Rainfall%20%5BRainfall%5D"](http://hilltop.gw.govt.nz/data.hts?Service=Hilltop&Request=GetData&Site=Abbots%20Creek%20at%20Featherston&Measurement=Daily%20Rainfall%20%5BRainfall%5D),
      "type": "application/xml",
      "roles": [
        "data"
      ],
      "title": "Hilltop GetData (latest): Abbots Creek at Featherston / Daily Rainfall [Rainfall]"
    }
  },

I get the following when hovering over the "Download" or "Copy URL" buttons in STAC browser, as well as when I click on it
https://[hilltop.gw.govt.nz/data.hts?Service=Hilltop&Request=GetData&Site=Abbots+Creek+at+Featherston&Measurement=Daily+Rainfall+%5BRainfall%5D

Latter URL from STAC browser does not work, the URL as present in the asset definition is fine.

[m-mohr]

Is there something wrong with the example?

This is not a valid href.
"href": ["http://hilltop.gw.govt.nz/data.hts?Service=Hilltop&Request=GetData&Site=Abbots%20Creek%20at%20Featherston&Measurement=Daily%20Rainfall%20%5BRainfall%5D"](http://hilltop.gw.govt.nz/data.hts?Service=Hilltop&Request=GetData&Site=Abbots%20Creek%20at%20Featherston&Measurement=Daily%20Rainfall%20%5BRainfall%5D),

[m-mohr]

If it's about the %20 vs + as space character, we pass URLs through urijs for various reasons and it seems + is their default.

According to https://stackoverflow.com/questions/2678551/when-should-space-be-encoded-to-plus-or-20 in URLs it should be %20 though, not +. So I'm looking into fixing it, but it's scattered through the whole codebase...

[m-mohr]

@drandyziegler Please verify whether this PR works for you: #809