Skip to content

Commit 853ac7d

Browse files
sk593sk593
committed
testing
Signed-off-by: sk593 <shruthikumar@microsoft.com>
1 parent 1d2085d commit 853ac7d

File tree

3 files changed

+71
-66
lines changed

3 files changed

+71
-66
lines changed

‎.github/scripts/configure-azure-provider.sh‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ fi
6262

6363
printf "\033[34;1m=>\033[0m Configuring Azure provider for Radius tests\n"
6464

65-
if ! az group exists --name "$AZURE_RESOURCE_GROUP" --subscription "$AZURE_SUBSCRIPTION_ID" >/dev/null 2>&1; then
65+
# az group exists returns "true" or "false" as text, not an exit code
66+
if [[ "$(az group exists --name "$AZURE_RESOURCE_GROUP" --subscription "$AZURE_SUBSCRIPTION_ID" 2>/dev/null)" != "true" ]]; then
6667
echo "Error: Azure resource group '$AZURE_RESOURCE_GROUP' not found. Create it before running configure-azure-provider." >&2
6768
exit 1
6869
fi

‎.github/workflows/validate-azure-recipes.yaml‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,13 @@ jobs:
7070
--name "$AZURE_RESOURCE_GROUP" \
7171
--subscription "$AZURE_SUBSCRIPTION_ID" \
7272
--tags creationTime=$current_time > /dev/null
73-
while ! az group exists --name "$AZURE_RESOURCE_GROUP" --subscription "$AZURE_SUBSCRIPTION_ID" &>/dev/null; do
74-
sleep 2
73+
# Wait for resource group to be fully available
74+
# az group exists returns "true" or "false" as text, not an exit code
75+
while [[ "$(az group exists --name "$AZURE_RESOURCE_GROUP" --subscription "$AZURE_SUBSCRIPTION_ID")" != "true" ]]; do
76+
echo "Waiting for resource group '$AZURE_RESOURCE_GROUP' to be available..."
77+
sleep 5
7578
done
79+
echo "Resource group '$AZURE_RESOURCE_GROUP' is ready"
7680
7781
- name: Setup Node
7882
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0

‎Compute/containers/test/app.bicep‎

Lines changed: 63 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
extension radius
22
extension containers
33
extension persistentVolumes
4-
extension secrets
5-
6-
param environment string
4+
// extension secrets
75

86
// Secure parameters with test defaults
9-
#disable-next-line secure-parameter-default @secure()
10-
param username string = 'admin'
11-
#disable-next-line secure-parameter-default @secure()
12-
param password string = 'c2VjcmV0cGFzc3dvcmQ='
13-
#disable-next-line secure-parameter-default @secure()
14-
param apiKey string = 'abc123xyz'
7+
// #disable-next-line secure-parameter-default @secure()
8+
// param username string = 'admin'
9+
// #disable-next-line secure-parameter-default @secure()
10+
// param password string = 'c2VjcmV0cGFzc3dvcmQ='
11+
// #disable-next-line secure-parameter-default @secure()
12+
// param apiKey string = 'abc123xyz'
13+
14+
param environment string
1515

1616
resource app 'Applications.Core/applications@2023-10-01-preview' = {
1717
name: 'containers-testapp'
@@ -31,10 +31,10 @@ resource myContainer 'Radius.Compute/containers@2025-08-01-preview' = {
3131
source: myPersistentVolume.id
3232
disableDefaultEnvVars: false
3333
}
34-
secrets: {
35-
source: secret.id
36-
disableDefaultEnvVars: false
37-
}
34+
// secrets: {
35+
// source: secret.id
36+
// disableDefaultEnvVars: false
37+
// }
3838
}
3939
containers: {
4040
web: {
@@ -49,30 +49,30 @@ resource myContainer 'Radius.Compute/containers@2025-08-01-preview' = {
4949
}
5050
}
5151
env: {
52-
CONNECTIONS_SECRET_USERNAME: {
53-
valueFrom: {
54-
secretKeyRef: {
55-
secretName: secret.name
56-
key: 'username'
57-
}
58-
}
59-
}
60-
CONNECTIONS_SECRET_APIKEY: {
61-
valueFrom: {
62-
secretKeyRef: {
63-
secretName: secret.name
64-
key: 'apikey'
65-
}
66-
}
67-
}
68-
CONNECTIONS_SECRET_PASSWORD: {
69-
valueFrom: {
70-
secretKeyRef: {
71-
secretName: secret.name
72-
key: 'password'
73-
}
74-
}
75-
}
52+
// CONNECTIONS_SECRET_USERNAME: {
53+
// valueFrom: {
54+
// secretKeyRef: {
55+
// secretName: secret.name
56+
// key: 'username'
57+
// }
58+
// }
59+
// }
60+
// CONNECTIONS_SECRET_APIKEY: {
61+
// valueFrom: {
62+
// secretKeyRef: {
63+
// secretName: secret.name
64+
// key: 'apikey'
65+
// }
66+
// }
67+
// }
68+
// CONNECTIONS_SECRET_PASSWORD: {
69+
// valueFrom: {
70+
// secretKeyRef: {
71+
// secretName: secret.name
72+
// key: 'password'
73+
// }
74+
// }
75+
// }
7676
}
7777
volumeMounts: [
7878
{
@@ -83,10 +83,10 @@ resource myContainer 'Radius.Compute/containers@2025-08-01-preview' = {
8383
volumeName: 'cache'
8484
mountPath: '/tmp/cache'
8585
}
86-
{
87-
volumeName: 'secrets'
88-
mountPath: '/etc/secrets'
89-
}
86+
// {
87+
// volumeName: 'secrets'
88+
// mountPath: '/etc/secrets'
89+
// }
9090
]
9191
resources: {
9292
requests: {
@@ -151,9 +151,9 @@ resource myContainer 'Radius.Compute/containers@2025-08-01-preview' = {
151151
medium: 'memory'
152152
}
153153
}
154-
secrets: {
155-
secretName: secret.name
156-
}
154+
// secrets: {
155+
// secretName: secret.name
156+
// }
157157
}
158158
extensions: {
159159
daprSidecar: {
@@ -185,22 +185,22 @@ resource myPersistentVolume 'Radius.Compute/persistentVolumes@2025-08-01-preview
185185
}
186186
}
187187

188-
resource secret 'Radius.Security/secrets@2025-08-01-preview' = {
189-
name: 'app-secrets-${uniqueString(deployment().name)}'
190-
properties: {
191-
environment: environment
192-
application: app.id
193-
data: {
194-
username: {
195-
value: username
196-
}
197-
password: {
198-
value: password
199-
encoding: 'base64'
200-
}
201-
apikey: {
202-
value: apiKey
203-
}
204-
}
205-
}
206-
}
188+
// resource secret 'Radius.Security/secrets@2025-08-01-preview' = {
189+
// name: 'app-secrets-${uniqueString(deployment().name)}'
190+
// properties: {
191+
// environment: environment
192+
// application: app.id
193+
// data: {
194+
// username: {
195+
// value: username
196+
// }
197+
// password: {
198+
// value: password
199+
// encoding: 'base64'
200+
// }
201+
// apikey: {
202+
// value: apiKey
203+
// }
204+
// }
205+
// }
206+
// }

0 commit comments

Comments
 (0)