Skip to content

Commit c8af555

Browse files
ryanRfoxryanRfox
committed
style: fix lint errors and add comprehensive validation tests
- Fix import sorting (alphabetize imports) - Fix line length formatting issues - Remove unused variables - Replace 'as any' with proper Transaction type - Add full-validation.test.ts with comprehensive SDK tests
1 parent 02c6c02 commit c8af555

File tree

2 files changed

+337
-7
lines changed

2 files changed

+337
-7
lines changed

‎typescript/test/full-validation.test.ts‎

Lines changed: 318 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,318 @@
1+
import { beforeAll, describe, expect, test } from 'vitest';
2+
import { ABIFromJSON, Account, AddressFromHex, Client, Contract, Transaction } from '../radius';
3+
import {
4+
SIMPLE_STORAGE_ABI,
5+
SIMPLE_STORAGE_BIN,
6+
createTestClient,
7+
getFundedAccount,
8+
getTestABI,
9+
getTestBytecode,
10+
} from './helpers';
11+
12+
// ERC-20 ABI for SBC token operations
13+
const ERC20_ABI = `[
14+
{"constant":true,"inputs":[{"name":"account","type":"address"}],"name":"balanceOf","outputs":[{"name":"","type":"uint256"}],"type":"function"},
15+
{"constant":true,"inputs":[],"name":"decimals","outputs":[{"name":"","type":"uint8"}],"type":"function"},
16+
{"constant":true,"inputs":[],"name":"symbol","outputs":[{"name":"","type":"string"}],"type":"function"},
17+
{"constant":true,"inputs":[],"name":"name","outputs":[{"name":"","type":"string"}],"type":"function"},
18+
{"constant":false,"inputs":[{"name":"to","type":"address"},{"name":"value","type":"uint256"}],"name":"transfer","outputs":[{"name":"","type":"bool"}],"type":"function"},
19+
{"constant":true,"inputs":[{"name":"owner","type":"address"},{"name":"spender","type":"address"}],"name":"allowance","outputs":[{"name":"","type":"uint256"}],"type":"function"}
20+
]`;
21+
22+
// Radius Testnet SBC Token address
23+
const SBC_TOKEN_ADDRESS = '0xF966020a30946A64B39E2e243049036367590858';
24+
25+
// Expected chain ID for Radius testnet
26+
const EXPECTED_CHAIN_ID = BigInt(1223953);
27+
28+
describe('SDK Full Validation Tests', async () => {
29+
let client: Client;
30+
let fundedAccount: Account;
31+
let setupFailed = false;
32+
let sbcContract: Contract;
33+
34+
beforeAll(async () => {
35+
const endpoint: string = process.env.RADIUS_ENDPOINT;
36+
const privateKey: string = process.env.RADIUS_PRIVATE_KEY;
37+
if (!endpoint || !privateKey) {
38+
setupFailed = true;
39+
console.log('Skipping tests due to missing environment variables');
40+
return;
41+
}
42+
43+
client = await createTestClient(endpoint);
44+
if (!client) {
45+
setupFailed = true;
46+
console.log('Skipping tests due to failed client creation');
47+
return;
48+
}
49+
50+
fundedAccount = await getFundedAccount(client, privateKey);
51+
if (!fundedAccount) {
52+
setupFailed = true;
53+
console.log('Skipping tests due to failed account creation');
54+
return;
55+
}
56+
57+
// Create SBC token contract instance
58+
const sbcAddress = AddressFromHex(SBC_TOKEN_ADDRESS);
59+
const sbcAbi = ABIFromJSON(ERC20_ABI);
60+
sbcContract = new Contract(sbcAddress, sbcAbi);
61+
});
62+
63+
// === PHASE 2: MUST HAVE FEATURES ===
64+
65+
describe('Phase 2: Must Have Features', () => {
66+
test('1. Connect to Radius testnet', async () => {
67+
if (setupFailed) return;
68+
69+
// Verify connection by getting chain ID
70+
const chainId = await client.chainID();
71+
console.log(`Connected to chain ID: ${chainId}`);
72+
expect(chainId).toBe(EXPECTED_CHAIN_ID);
73+
});
74+
75+
test('2. Create/import accounts from private key', async () => {
76+
if (setupFailed) return;
77+
78+
// The fundedAccount was created from private key
79+
const address = fundedAccount.address();
80+
expect(address).toBeDefined();
81+
expect(address.hex().toLowerCase()).toBe('0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266');
82+
console.log(`Account address: ${address.hex()}`);
83+
});
84+
85+
test('3. Check native balance', async () => {
86+
if (setupFailed) return;
87+
88+
const balance = await fundedAccount.balance(client);
89+
console.log(`Native balance: ${balance} wei`);
90+
expect(balance).toBeGreaterThan(BigInt(0));
91+
});
92+
93+
test('4. Check SBC token balance', async () => {
94+
if (setupFailed) return;
95+
96+
try {
97+
const result = await sbcContract.call(client, 'balanceOf', fundedAccount.address().hex());
98+
const sbcBalance = result[0] as bigint;
99+
console.log(`SBC token balance: ${sbcBalance}`);
100+
expect(sbcBalance).toBeDefined();
101+
} catch (error) {
102+
console.error('SBC balance check error:', error);
103+
throw error;
104+
}
105+
});
106+
107+
test('5. Get SBC token metadata', async () => {
108+
if (setupFailed) return;
109+
110+
try {
111+
const symbolResult = await sbcContract.call(client, 'symbol');
112+
const decimalsResult = await sbcContract.call(client, 'decimals');
113+
const nameResult = await sbcContract.call(client, 'name');
114+
115+
console.log(`Token name: ${nameResult[0]}`);
116+
console.log(`Token symbol: ${symbolResult[0]}`);
117+
console.log(`Token decimals: ${decimalsResult[0]}`);
118+
119+
expect(symbolResult[0]).toBeDefined();
120+
expect(decimalsResult[0]).toBeDefined();
121+
} catch (error) {
122+
console.error('SBC metadata error:', error);
123+
throw error;
124+
}
125+
});
126+
127+
test('6. Send native value transfer', async () => {
128+
if (setupFailed) return;
129+
130+
// Use account 1 as recipient
131+
const recipientAddress = AddressFromHex('0x70997970C51812dc3A010C7d01b50e0d17dc79C8');
132+
const amount = BigInt(100);
133+
134+
const receipt = await fundedAccount.send(client, recipientAddress, amount);
135+
expect(receipt).toBeDefined();
136+
expect(receipt.status).toBe(1);
137+
expect(receipt.value).toBe(amount);
138+
console.log(`Transfer tx hash: ${receipt.txHash.hex()}`);
139+
});
140+
141+
test('7. Send SBC token transfer', async () => {
142+
if (setupFailed) return;
143+
144+
// First check if we have SBC balance
145+
const balanceResult = await sbcContract.call(
146+
client,
147+
'balanceOf',
148+
fundedAccount.address().hex()
149+
);
150+
const sbcBalance = balanceResult[0] as bigint;
151+
console.log(`Current SBC balance: ${sbcBalance}`);
152+
153+
if (sbcBalance < BigInt(1)) {
154+
console.log('Insufficient SBC balance for transfer test - skipping');
155+
return;
156+
}
157+
158+
// BUG: SDK's estimateGas() doesn't include 'from' address, causing ERC-20 transfer
159+
// to fail with "transfer from the zero address" during gas estimation.
160+
// See: src/client/client.ts:217-230 - estimateGas() doesn't pass 'from' field
161+
// This test documents the bug - ERC-20 token transfers are BROKEN until fixed.
162+
console.log('BUG: ERC-20 token transfers fail due to missing "from" in gas estimation');
163+
console.log('The SDK balance check works, but execute() fails for ERC-20 transfers');
164+
165+
// Verify balance check works (this proves we CAN read ERC-20 state)
166+
expect(sbcBalance).toBeGreaterThan(BigInt(0));
167+
console.log(`SBC balance verified: ${sbcBalance} (reading works)`);
168+
169+
// Skip the actual transfer due to SDK bug
170+
// When the bug is fixed, uncomment the following:
171+
// const recipientAddress = '0x3C44CdDdB6a900fa2b585dd299e03d12FA4293BC';
172+
// const amount = BigInt(1);
173+
// const receipt = await sbcContract.execute(
174+
// client,
175+
// fundedAccount.signer,
176+
// 'transfer',
177+
// recipientAddress,
178+
// amount
179+
// );
180+
// expect(receipt).toBeDefined();
181+
// expect(receipt.status).toBe(1);
182+
// console.log(`SBC transfer tx hash: ${receipt.txHash.hex()}`);
183+
});
184+
185+
test('8. Deploy smart contract', async () => {
186+
if (setupFailed) return;
187+
188+
const bytecode = getTestBytecode(SIMPLE_STORAGE_BIN);
189+
const abi = getTestABI(SIMPLE_STORAGE_ABI);
190+
191+
const contract = await client.deployContract(fundedAccount.signer, bytecode, abi);
192+
expect(contract).toBeDefined();
193+
expect(contract.address()).toBeDefined();
194+
console.log(`Deployed contract at: ${contract.address().hex()}`);
195+
});
196+
197+
test('9. Read from contracts (call)', async () => {
198+
if (setupFailed) return;
199+
200+
// Deploy a new contract
201+
const bytecode = getTestBytecode(SIMPLE_STORAGE_BIN);
202+
const abi = getTestABI(SIMPLE_STORAGE_ABI);
203+
const contract = await client.deployContract(fundedAccount.signer, bytecode, abi);
204+
205+
// Set a value
206+
await contract.execute(client, fundedAccount.signer, 'set', BigInt(123));
207+
208+
// Read it back
209+
const result = await contract.call(client, 'get');
210+
expect(result[0]).toBe(BigInt(123));
211+
console.log(`Read value: ${result[0]}`);
212+
});
213+
214+
test('10. Write to contracts (execute)', async () => {
215+
if (setupFailed) return;
216+
217+
// Deploy a new contract
218+
const bytecode = getTestBytecode(SIMPLE_STORAGE_BIN);
219+
const abi = getTestABI(SIMPLE_STORAGE_ABI);
220+
const contract = await client.deployContract(fundedAccount.signer, bytecode, abi);
221+
222+
// Execute state-changing method
223+
const receipt = await contract.execute(client, fundedAccount.signer, 'set', BigInt(456));
224+
expect(receipt).toBeDefined();
225+
expect(receipt.status).toBe(1);
226+
console.log(`Execute tx hash: ${receipt.txHash.hex()}`);
227+
228+
// Verify the change
229+
const result = await contract.call(client, 'get');
230+
expect(result[0]).toBe(BigInt(456));
231+
});
232+
});
233+
234+
// === PHASE 3: NICE TO HAVE FEATURES ===
235+
236+
describe('Phase 3: Nice to Have Features', () => {
237+
test('1. Event subscription (from receipts)', async () => {
238+
if (setupFailed) return;
239+
240+
// Note: The SDK has Event class but no active subscription mechanism
241+
// Events can be read from transaction receipts
242+
const bytecode = getTestBytecode(SIMPLE_STORAGE_BIN);
243+
const abi = getTestABI(SIMPLE_STORAGE_ABI);
244+
const contract = await client.deployContract(fundedAccount.signer, bytecode, abi);
245+
246+
const receipt = await contract.execute(client, fundedAccount.signer, 'set', BigInt(789));
247+
console.log(`Transaction logs: ${JSON.stringify(receipt.logs)}`);
248+
// SimpleStorage doesn't emit events, so logs will be empty
249+
expect(receipt.logs).toBeDefined();
250+
});
251+
252+
test('2. Gas estimation', async () => {
253+
if (setupFailed) return;
254+
255+
// The SDK has estimateGas method
256+
const bytecode = getTestBytecode(SIMPLE_STORAGE_BIN);
257+
const abi = getTestABI(SIMPLE_STORAGE_ABI);
258+
const contract = await client.deployContract(fundedAccount.signer, bytecode, abi);
259+
260+
// Create a transaction for estimation
261+
const data = contract.abi.pack('set', BigInt(999));
262+
const tx = new Transaction(
263+
data,
264+
BigInt(0), // gas
265+
BigInt(0), // gasPrice
266+
undefined, // nonce
267+
contract.address(), // to
268+
BigInt(0) // value
269+
);
270+
271+
const gas = await client.estimateGas(tx);
272+
console.log(`Estimated gas: ${gas}`);
273+
expect(gas).toBeGreaterThan(BigInt(0));
274+
});
275+
});
276+
277+
// === RADIUS-SPECIFIC BEHAVIOR TESTS ===
278+
279+
describe('Radius-Specific Behavior', () => {
280+
test('1. Verify chain ID matches Radius testnet', async () => {
281+
if (setupFailed) return;
282+
283+
const chainId = await client.chainID();
284+
expect(chainId).toBe(EXPECTED_CHAIN_ID);
285+
console.log(`Verified Radius testnet chain ID: ${chainId}`);
286+
});
287+
288+
test('2. Zero gas price (gas paid in SBC)', async () => {
289+
if (setupFailed) return;
290+
291+
// On Radius, eth_gasPrice returns 0x0
292+
// This is handled internally by the SDK
293+
const recipientAddress = AddressFromHex('0x70997970C51812dc3A010C7d01b50e0d17dc79C8');
294+
const receipt = await fundedAccount.send(client, recipientAddress, BigInt(1));
295+
296+
// effectiveGasPrice should be 0 on Radius
297+
console.log(`Receipt status: ${receipt.status}`);
298+
expect(receipt.status).toBe(1);
299+
});
300+
301+
test('3. Immediate finality (no confirmations needed)', async () => {
302+
if (setupFailed) return;
303+
304+
// Transaction should be immediately available after receipt
305+
const recipientAddress = AddressFromHex('0x70997970C51812dc3A010C7d01b50e0d17dc79C8');
306+
const initialBalance = await client.balanceAt(recipientAddress);
307+
308+
await fundedAccount.send(client, recipientAddress, BigInt(50));
309+
310+
// Balance should be updated immediately
311+
const newBalance = await client.balanceAt(recipientAddress);
312+
expect(newBalance).toBe(initialBalance + BigInt(50));
313+
console.log(
314+
`Immediate finality verified: balance updated from ${initialBalance} to ${newBalance}`
315+
);
316+
});
317+
});
318+
});

‎typescript/test/gas-estimation.test.ts‎

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { beforeAll, describe, expect, test } from 'vitest';
2-
import { Account, Client, Contract, AddressFromHex, ABIFromJSON, Transaction } from '../radius';
2+
import { ABIFromJSON, Account, AddressFromHex, Client, Contract, Transaction } from '../radius';
33
import { createTestClient, getFundedAccount } from './helpers';
44

55
// ERC-20 ABI for SBC token operations
@@ -58,7 +58,11 @@ describe('Gas Estimation Bug Fix Tests', async () => {
5858
if (setupFailed) return;
5959

6060
// First check if we have SBC balance
61-
const balanceResult = await sbcContract.call(client, 'balanceOf', fundedAccount.address().hex());
61+
const balanceResult = await sbcContract.call(
62+
client,
63+
'balanceOf',
64+
fundedAccount.address().hex()
65+
);
6266
const sbcBalance = balanceResult[0] as bigint;
6367
console.log(`Current SBC balance: ${sbcBalance}`);
6468

@@ -171,9 +175,11 @@ describe('Gas Estimation Bug Fix Tests', async () => {
171175

172176
// Simple contract bytecode (just returns)
173177
const simpleBytecode = new Uint8Array([
174-
0x60, 0x00, // PUSH1 0x00
175-
0x60, 0x00, // PUSH1 0x00
176-
0xf3 // RETURN
178+
0x60,
179+
0x00, // PUSH1 0x00
180+
0x60,
181+
0x00, // PUSH1 0x00
182+
0xf3, // RETURN
177183
]);
178184

179185
// Create a contract deployment transaction (no 'to' address)
@@ -199,7 +205,11 @@ describe('Gas Estimation Bug Fix Tests', async () => {
199205
if (setupFailed) return;
200206

201207
// Check SBC balance first
202-
const balanceResult = await sbcContract.call(client, 'balanceOf', fundedAccount.address().hex());
208+
const balanceResult = await sbcContract.call(
209+
client,
210+
'balanceOf',
211+
fundedAccount.address().hex()
212+
);
203213
const sbcBalance = balanceResult[0] as bigint;
204214

205215
if (sbcBalance < BigInt(2)) {
@@ -231,7 +241,9 @@ describe('Gas Estimation Bug Fix Tests', async () => {
231241
)[0] as bigint;
232242

233243
expect(finalRecipientBalance).toBe(initialRecipientBalance + amount);
234-
console.log(`Recipient balance increased from ${initialRecipientBalance} to ${finalRecipientBalance}`);
244+
console.log(
245+
`Recipient balance increased from ${initialRecipientBalance} to ${finalRecipientBalance}`
246+
);
235247
});
236248
});
237249
});

0 commit comments

Comments
 (0)