Replies: 1 comment
-
Hey @felquis, thanks for raising this. Whilst it makes sense for icons as they are usually rendered inline along text (color/currentColor), that isn't the case here for the arrow as it doesn't live in a textual context. That's why I think it makes more sense to style using fill. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
On this line:
primitives/packages/react/arrow/src/Arrow.tsx
Line 28 in 4ee9d36
It would be helpful if it uses fill="currentColor" cause I could apply color directly on
<Popover.Arrow className="text-gray-primary" />
Also, SVG fill=currentColor is very wide spread without @react-icons/all-icons which make it kind of the expected behavior of most SVGs.
What do you think?
Beta Was this translation helpful? Give feedback.
All reactions